Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete avatar if a user is deleted #19929

Merged
merged 1 commit into from
Apr 27, 2020
Merged

Delete avatar if a user is deleted #19929

merged 1 commit into from
Apr 27, 2020

Conversation

juliushaertl
Copy link
Member

Make sure avatars are properly cleaned up if a user is deleted

@juliushaertl juliushaertl added this to the Nextcloud 19 milestone Mar 13, 2020
@rullzer
Copy link
Member

rullzer commented Mar 23, 2020

@juliushaertl mind to address the comments?

@rullzer rullzer added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Mar 24, 2020
@blizzz
Copy link
Member

blizzz commented Mar 25, 2020 •
edited
Loading

Now you have failing tests though

...
/drone/src/lib/private/User/User.php:243 
/drone/src/apps/settings/tests/Controller/AdminSettingsControllerTest.php:96

@juliushaertl
Copy link
Member Author

Let me restart, since those run fine locally.

@juliushaertl juliushaertl added 2. developing Work in progress and removed 4. to release Ready to be released and/or waiting for tests to finish labels Mar 30, 2020
This was referenced Apr 4, 2020
Merged
Merged
This was referenced Apr 15, 2020
Merged
Merged
@rullzer rullzer mentioned this pull request Apr 23, 2020
Merged
11 tasks
@juliushaertl
Delete avatar if a user is deleted
d74e904 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliushaertl
Copy link
Member Author

Let's see if that works.

@juliushaertl juliushaertl added 4. to release Ready to be released and/or waiting for tests to finish and removed 2. developing Work in progress labels Apr 24, 2020
@MorrisJobke MorrisJobke merged commit 673267c into master Apr 27, 2020
@MorrisJobke MorrisJobke deleted the bugfix/user-delete-avatar branch April 27, 2020 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rullzer rullzer rullzer approved these changes

@nickvergessen nickvergessen nickvergessen approved these changes

@kesselb kesselb kesselb left review comments

@georgehrke georgehrke georgehrke approved these changes

@blizzz blizzz blizzz approved these changes

Assignees
No one assigned
Labels
4. to release Ready to be released and/or waiting for tests to finish bug feature: users and groups
Projects
None yet
Milestone
Nextcloud 19
Development

Successfully merging this pull request may close these issues.
7 participants
@juliushaertl @rullzer @blizzz @nickvergessen @georgehrke @kesselb @MorrisJobke