New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only save login credentials in database once there is an external storage that needs it #21037
Conversation
|
This patch also helps with #6343 as the data is not written anymore on login. How do you detect changed credentials without listening to postLogin? |
Forgot about that |
done |
d2b31d6
to
c89db6c
Compare
Nice |
c89db6c
to
39c0e4b
Compare
39c0e4b
to
48909ff
Compare
…rage that needs it Signed-off-by: Robin Appelman <robin@icewind.nl>
…ured using them Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
|
Let me fix this :) |
48909ff
to
91cfd49
Compare
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
91cfd49
to
0b0cc48
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and works
|
Here are the logs for the failed build: Status of 31206: failuremysql8.0-php7.2Show full logintegration-external-storageCould not fetch logs |
Also fixes #6343