Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include e-mail shares when transferring ownership #21797

Merged
merged 2 commits into from Aug 20, 2020

Conversation

rawtaz
Copy link
Contributor

@rawtaz rawtaz commented Jul 11, 2020

E-mail shares weren't included in the processing of shares when using the occ files:transfer-ownership command, so they'd be lost (not visible in either the former or the new account). This commit fixes that.

E-mail shares weren't included in the processing of shares when using the `occ files:transfer-ownership` command, so they'd be lost (not visible in either the former or the new account). This commit fixes that.
@rawtaz
Copy link
Contributor Author

rawtaz commented Jul 11, 2020

This was a quick edit when encountering this bug during first trying out Nextcloud. Is there something missing or should I mark it non-draft? It would be great if someone else could test it as well!

@rawtaz rawtaz marked this pull request as ready for review July 11, 2020 22:17
@rawtaz
Copy link
Contributor Author

rawtaz commented Jul 11, 2020

Regarding checks:

  • There are tests failing that cannot possibly be due to this change I made.
  • What the DCO regulates is already covered by GitHub's terms when I file this PR.

Hopefully this can be merged. Otherwise someone with more knowledge of the Nextcloud codebase can perhaps fix the problem in a commit/PR of their own.

@kesselb kesselb added this to the Nextcloud 20 milestone Jul 12, 2020
@kesselb kesselb added 3. to review Waiting for reviews bug enhancement and removed bug labels Jul 12, 2020
@rawtaz
Copy link
Contributor Author

rawtaz commented Jul 12, 2020

Question: Are there other share types that are missing too and that should be added in the same code? Better do it now if that is the case.

@MorrisJobke MorrisJobke mentioned this pull request Aug 11, 2020
57 tasks
@MorrisJobke MorrisJobke merged commit 420a376 into nextcloud:master Aug 20, 2020
@welcome
Copy link

welcome bot commented Aug 20, 2020

Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22

@rawtaz rawtaz deleted the patch-1 branch August 20, 2020 22:03
@rawtaz
Copy link
Contributor Author

rawtaz commented Aug 24, 2020

Sorry to ask this here, but I haven't been able to find an answer on the other channels I've tried:

  • What practical use does accepting an invite to the @nextcloud organization here on GitHub have? What can you do with it? What are the intentions when inviting people to it? I'm not sure if it's a social "belong to the group" thing, or if it has a more practical function.

  • Is such an invite something that is sent out automatically to contributors when their PRs are merged, or is it something that's done manually and on an individual basis (as opposed to everyone getting a PR merged)? I received one and am not sure why, because the PR I filed was really tiny :P

Thanks!

@nickvergessen
Copy link
Member

Being in the group means you can push your branches to our repo instead of having to maintain a fork in your user. Also it allows to request reviews in case follow up work is needed.

Inviting is done manually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants