Silence duplicate session warnings

[rullzer]

Fixes #20490
Repalces #21468

Basically restoring the old behavior.

[rullzer]

/backport to stable19

[faily-bot]

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 31777: failure

mariadb10.1-php7.2

Show full log

There was 1 error:

1) OCA\DAV\Tests\unit\Connector\Sabre\RequestTest\EncryptionMasterKeyUploadTest::testUploadOverWriteReadLocked
TypeError: Argument 1 passed to OCA\DAV\CalDAV\Activity\Backend::onCalendarAdd() must be of the type array, null given, called in /drone/src/apps/dav/lib/AppInfo/Application.php on line 184

/drone/src/apps/dav/lib/CalDAV/Activity/Backend.php:72
/drone/src/apps/dav/lib/AppInfo/Application.php:184
/drone/src/3rdparty/symfony/event-dispatcher/EventDispatcher.php:264
/drone/src/3rdparty/symfony/event-dispatcher/EventDispatcher.php:239
/drone/src/3rdparty/symfony/event-dispatcher/EventDispatcher.php:73
/drone/src/lib/private/EventDispatcher/SymfonyAdapter.php:84
/drone/src/apps/dav/lib/CalDAV/CalDavBackend.php:771
/drone/src/apps/dav/lib/HookManager.php:157
/drone/src/apps/dav/lib/AppInfo/Application.php:131
/drone/src/3rdparty/symfony/event-dispatcher/EventDispatcher.php:264
/drone/src/3rdparty/symfony/event-dispatcher/EventDispatcher.php:239
/drone/src/3rdparty/symfony/event-dispatcher/EventDispatcher.php:73
/drone/src/lib/private/EventDispatcher/SymfonyAdapter.php:84
/drone/src/lib/private/User/Session.php:566
/drone/src/lib/private/User/Session.php:412
/drone/src/lib/private/User/Session.php:621
/drone/src/lib/private/User/Session.php:366
/drone/src/apps/dav/tests/unit/Connector/Sabre/RequestTest/Auth.php:84
/drone/src/3rdparty/sabre/dav/lib/DAV/Auth/Plugin.php:193
/drone/src/3rdparty/sabre/dav/lib/DAV/Auth/Plugin.php:144
/drone/src/3rdparty/sabre/event/lib/WildcardEmitterTrait.php:89
/drone/src/3rdparty/sabre/dav/lib/DAV/Server.php:458
/drone/src/3rdparty/sabre/dav/lib/DAV/Server.php:251
/drone/src/3rdparty/sabre/dav/lib/DAV/Server.php:319
/drone/src/apps/dav/tests/unit/Connector/Sabre/RequestTest/RequestTestCase.php:134
/drone/src/apps/dav/tests/unit/Connector/Sabre/RequestTest/RequestTestCase.php:116
/drone/src/apps/dav/tests/unit/Connector/Sabre/RequestTest/UploadTest.php:79

--

There were 2 warnings:

1) Test\Files\ViewTest::testRenameFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

2) Test\Files\ViewTest::testCopyFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

--

There was 1 failure:

1) Test\SystemTag\SystemTagManagerTest::testUpdateTagDuplicate with data set #0 (array('one', true, true), array('two', true, true))
Failed asserting that exception of type "OCP\SystemTag\TagNotFoundException" matches expected exception "OCP\SystemTag\TagAlreadyExistsException". Message was: "Tag does not exist" at
/drone/src/lib/private/SystemTag/SystemTagManager.php:237
/drone/src/tests/lib/SystemTag/SystemTagManagerTest.php:382
.

mysql8.0-php7.2

Show full log

There was 1 error:

1) OCA\Federation\Tests\DbHandlerTest::testGetServerById
Exception: No Server found with ID: 0

/drone/src/apps/federation/lib/DbHandler.php:127
/drone/src/apps/federation/tests/DbHandlerTest.php:126

--

There were 2 warnings:

1) Test\Files\ViewTest::testRenameFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

2) Test\Files\ViewTest::testCopyFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

--

There was 1 failure:

1) Test\Repair\OldGroupMembershipSharesTest::testRun
Failed asserting that two arrays are equal.
--- Expected
+++ Actual
@@ @@
     0 => Array (...)
     1 => Array (...)
     2 => Array (
-        'id' => '0'
+        'id' => '4'
     )
     3 => Array (...)
     4 => Array (...)
 )

/drone/src/tests/lib/Repair/OldGroupMembershipSharesTest.php:83

acceptance-app-files

• tests/acceptance/features/app-files.feature:262

Show full log

  Scenario: unmarking a file as favorite causes the file list to be sorted again                          # /drone/src/tests/acceptance/features/app-files.feature:262
    Given I am logged in                                                                                  # LoginPageContext::iAmLoggedIn()
    And I create a new folder named "A name alphabetically lower than welcome.txt"                        # FileListContext::iCreateANewFolderNamed()
    And I see that "A name alphabetically lower than welcome.txt" precedes "welcome.txt" in the file list # FileListContext::iSeeThatPrecedesInTheFileList()
    And I close the details view                                                                          # FilesAppContext::iCloseTheDetailsView()
    And I see that the details view is closed                                                             # FilesAppContext::iSeeThatTheDetailsViewIsClosed()
    And I mark "welcome.txt" as favorite                                                                  # FileListContext::iMarkAsFavorite()
    And I see that "welcome.txt" is marked as favorite                                                    # FileListContext::iSeeThatIsMarkedAsFavorite()
    And I see that "welcome.txt" precedes "A name alphabetically lower than welcome.txt" in the file list # FileListContext::iSeeThatPrecedesInTheFileList()
    When I unmark "welcome.txt" as favorite                                                               # FileListContext::iUnmarkAsFavorite()
    Then I see that "welcome.txt" is not marked as favorite                                               # FileListContext::iSeeThatIsNotMarkedAsFavorite()
      Not favorited state icon for file welcome.txt in file list could not be found after 100 seconds (NoSuchElementException)
    And I see that "A name alphabetically lower than welcome.txt" precedes "welcome.txt" in the file list # FileListContext::iSeeThatPrecedesInTheFileList()