New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable10] Throw an exception when a shipped app was not replaced before the update #2464

Merged
merged 3 commits into from Dec 16, 2016

Conversation

Projects
None yet
6 participants
@nickvergessen
Member

nickvergessen commented Dec 2, 2016

Backport of #1973 and #2153

@MorrisJobke @rullzer

nickvergessen and others added some commits Nov 2, 2016

Throw an exception when a shipped app was not replaced before the update
Signed-off-by: Joas Schilling <coding@schilljs.com>
add explanatory text of what to do on app version error
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
Show all in one message
Signed-off-by: Joas Schilling <coding@schilljs.com>
@mention-bot

This comment has been minimized.

Show comment
Hide comment
@mention-bot

mention-bot Dec 2, 2016

@nickvergessen, thanks for your PR! By analyzing the history of the files in this pull request, we identified @LukasReschke, @icewind1991 and @bartv2 to be potential reviewers.

mention-bot commented Dec 2, 2016

@nickvergessen, thanks for your PR! By analyzing the history of the files in this pull request, we identified @LukasReschke, @icewind1991 and @bartv2 to be potential reviewers.

@rullzer

This comment has been minimized.

Show comment
Hide comment
@rullzer

rullzer Dec 16, 2016

Member

LGTM

Member

rullzer commented Dec 16, 2016

LGTM

@LukasReschke LukasReschke merged commit d739dfb into stable10 Dec 16, 2016

3 of 4 checks passed

approvals/lgtm 0 of 2 required approvals granted
Scrutinizer 3 new issues, 1 updated code elements
Details
continuous-integration/drone/pr the build was successful
Details
continuous-integration/drone/push the build was successful
Details

@LukasReschke LukasReschke deleted the backport-1973-dont-disable-shipped-apps-but-throw-instead branch Dec 16, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment