Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only return display name as editable when the user backend allows it #26461

Conversation

nickvergessen
Copy link
Member

Found by @tobiasKaminsky

Steps

  1. Have a server with a user backend that does not allow display name manipulation
  2. Get list of editable fields or try to send the request to edit the display name
  3. Displayname listed as editable, changing acted like everything is good, but value was unchanged at the end.

Now

Display name properly not returned as editable field and trying to change it returns the same thing as when the config allow_user_to_change_display_name is set to false

However we now check against the current users backend unless the user id is appended to the request.

@nickvergessen nickvergessen force-pushed the bugfix/noid/only-return-editable-displayname-field-when-allowed-by-backend branch from a9c1ba6 to 396ad3a Compare April 22, 2021 14:15
@nickvergessen nickvergessen added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Apr 26, 2021
@nickvergessen
Copy link
Member Author

/backport to stable21

Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen force-pushed the bugfix/noid/only-return-editable-displayname-field-when-allowed-by-backend branch from 60dc5c5 to 56f8fc4 Compare April 27, 2021 13:01
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen force-pushed the bugfix/noid/only-return-editable-displayname-field-when-allowed-by-backend branch from 56f8fc4 to 03b467b Compare April 27, 2021 13:28
@MorrisJobke MorrisJobke merged commit b971f69 into master Apr 28, 2021
@MorrisJobke MorrisJobke deleted the bugfix/noid/only-return-editable-displayname-field-when-allowed-by-backend branch April 28, 2021 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish bug feature: users and groups
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants