New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[10] Do not connect to database before creating it #2702

Merged
merged 1 commit into from Dec 16, 2016

Conversation

Projects
None yet
4 participants
@enoch85
Member

enoch85 commented Dec 15, 2016

Backport of #2670 to stable 10.

Signed-off-by: Daniel Hansson daniel@techandme.se

@mention-bot

This comment has been minimized.

Show comment
Hide comment
@mention-bot

mention-bot Dec 15, 2016

@enoch85, thanks for your PR! By analyzing the history of the files in this pull request, we identified @bartv2, @nickvergessen and @LukasReschke to be potential reviewers.

mention-bot commented Dec 15, 2016

@enoch85, thanks for your PR! By analyzing the history of the files in this pull request, we identified @bartv2, @nickvergessen and @LukasReschke to be potential reviewers.

@enoch85 enoch85 added this to the Nextcloud 10.0.3 milestone Dec 15, 2016

@nickvergessen

This comment has been minimized.

Show comment
Hide comment
@nickvergessen

nickvergessen Dec 15, 2016

Member

Missing sign-off

Member

nickvergessen commented Dec 15, 2016

Missing sign-off

@enoch85

This comment has been minimized.

Show comment
Hide comment
@enoch85

enoch85 Dec 15, 2016

Member

@nickvergessen Don't use git here, did it online. Will that be enough --^ ?

Member

enoch85 commented Dec 15, 2016

@nickvergessen Don't use git here, did it online. Will that be enough --^ ?

Do not connect to database before creating it
Signed-off-by: Joas Schilling <coding@schilljs.com>

@rullzer rullzer merged commit c8d391a into stable10 Dec 16, 2016

1 of 3 checks passed

continuous-integration/drone/pr the build failed
Details
continuous-integration/drone/push the build failed
Details
Scrutinizer No new issues
Details

@rullzer rullzer deleted the enoch85-patch-1 branch Dec 16, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment