New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[11] Do not connect to database before creating it #2703

Merged
merged 1 commit into from Dec 16, 2016

Conversation

Projects
None yet
4 participants
@enoch85
Member

enoch85 commented Dec 15, 2016

Backport of https://github.com/nextcloud/server/pull/2670/files to stable 11

Signed-off-by: Daniel Hansson daniel@techandme.se

@enoch85 enoch85 added this to the Nextcloud 11.0.1 milestone Dec 15, 2016

@mention-bot

This comment has been minimized.

Show comment
Hide comment
@mention-bot

mention-bot Dec 15, 2016

@enoch85, thanks for your PR! By analyzing the history of the files in this pull request, we identified @bartv2, @harry-7 and @nickvergessen to be potential reviewers.

mention-bot commented Dec 15, 2016

@enoch85, thanks for your PR! By analyzing the history of the files in this pull request, we identified @bartv2, @harry-7 and @nickvergessen to be potential reviewers.

@enoch85 enoch85 changed the title from Do not connect to database before creating it to [11] Do not connect to database before creating it Dec 15, 2016

@nickvergessen

This comment has been minimized.

Show comment
Hide comment
@nickvergessen

nickvergessen Dec 15, 2016

Member

Missing sign-off

Member

nickvergessen commented Dec 15, 2016

Missing sign-off

@enoch85

This comment has been minimized.

Show comment
Hide comment
@enoch85
Member

enoch85 commented Dec 15, 2016

@nickvergessen Sign-off?

@enoch85

This comment has been minimized.

Show comment
Hide comment
@enoch85
Member

enoch85 commented Dec 15, 2016

Do not connect to database before creating it
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen

This comment has been minimized.

Show comment
Hide comment
@nickvergessen

nickvergessen Dec 15, 2016

Member

Fixed both PRs

Member

nickvergessen commented Dec 15, 2016

Fixed both PRs

@rullzer rullzer merged commit 7a52f1d into stable11 Dec 16, 2016

0 of 2 checks passed

continuous-integration/drone/pr the build failed
Details
continuous-integration/drone/push the build failed
Details

@rullzer rullzer deleted the enoch85-patch-2 branch Dec 16, 2016

enoch85 added a commit to nextcloud/vm that referenced this pull request Dec 18, 2016

enoch85 added a commit to nextcloud/vm that referenced this pull request Jan 16, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment