New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable11] fix wording for apps mgmt buttons #2751

Merged
merged 1 commit into from Dec 22, 2016

Conversation

@nickvergessen
Member

nickvergessen commented Dec 19, 2016

Backport #2643

fix wording for apps mgmt buttons
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
@mention-bot

This comment has been minimized.

Show comment
Hide comment
@mention-bot

mention-bot Dec 19, 2016

@nickvergessen, thanks for your PR! By analyzing the history of the files in this pull request, we identified @LukasReschke, @jancborchardt and @MorrisJobke to be potential reviewers.

mention-bot commented Dec 19, 2016

@nickvergessen, thanks for your PR! By analyzing the history of the files in this pull request, we identified @LukasReschke, @jancborchardt and @MorrisJobke to be potential reviewers.

@LukasReschke

Not a critical issue but fair enough…

@blizzz

Bad to backport changes to translatable strings as we do not backport translations.

Dismissing my review as I agree with @blizzz.

@nickvergessen

This comment has been minimized.

Show comment
Hide comment
@nickvergessen

nickvergessen Dec 19, 2016

Member

We do backport translations as per @MorrisJobke

Member

nickvergessen commented Dec 19, 2016

We do backport translations as per @MorrisJobke

@blizzz

blizzz approved these changes Dec 19, 2016

@MorrisJobke

This comment has been minimized.

Show comment
Hide comment
@MorrisJobke

MorrisJobke Dec 20, 2016

Member

We do backport translations as per @MorrisJobke

Correct. But not to stable11 yet - I will add a fix for this.

Member

MorrisJobke commented Dec 20, 2016

We do backport translations as per @MorrisJobke

Correct. But not to stable11 yet - I will add a fix for this.

@MorrisJobke MorrisJobke merged commit a581e2f into stable11 Dec 22, 2016

1 of 2 checks passed

continuous-integration/drone/pr the build failed
Details
continuous-integration/drone/push the build was successful
Details

@MorrisJobke MorrisJobke deleted the backport-2643-apps-buttons-wording branch Dec 22, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment