New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable11] Don't set Content-Disposition header if one already exists #2949

Merged
merged 1 commit into from Jan 5, 2017

Conversation

Projects
None yet
6 participants
@nickvergessen
Member

nickvergessen commented Jan 5, 2017

If a Content-Disposition header is already set by another plugin we don't need to set another one as this breaks clients.

Backport of #2677

Don't set Content-Disposition header if one already exists
If a Content-Disposition header is already set by another plugin we don't need to set another one as this breaks clients.

Fixes #1992

Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
@mention-bot

This comment has been minimized.

Show comment
Hide comment
@mention-bot

mention-bot Jan 5, 2017

@nickvergessen, thanks for your PR! By analyzing the history of the files in this pull request, we identified @rullzer, @LukasReschke and @icewind1991 to be potential reviewers.

mention-bot commented Jan 5, 2017

@nickvergessen, thanks for your PR! By analyzing the history of the files in this pull request, we identified @rullzer, @LukasReschke and @icewind1991 to be potential reviewers.

@rullzer

rullzer approved these changes Jan 5, 2017

@MorrisJobke MorrisJobke merged commit 7f64890 into stable11 Jan 5, 2017

4 checks passed

codecov/patch 86.15% of diff hit (target 57.21%)
Details
codecov/project 57.22% (+0.01%) compared to d5c70fa
Details
continuous-integration/drone/pr the build was successful
Details
continuous-integration/drone/push the build was successful
Details

@MorrisJobke MorrisJobke deleted the backport-2677-fix-avatars-in-mail branch Jan 5, 2017

@jancborchardt

This comment has been minimized.

Show comment
Hide comment
@jancborchardt

jancborchardt Jan 5, 2017

Member

Nice, thanks a lot! :)

Member

jancborchardt commented Jan 5, 2017

Nice, thanks a lot! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment