New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve install process #30615
Improve install process #30615
Conversation
This comment has been minimized.
This comment has been minimized.
|
/backport to stable23 |
|
/backport to stable22 |
|
/backport to stable21 |
c74ebdb
to
fa57f34
Compare
|
I would say having the list of recommended apps before starting the install is nice too. Not sure if we should go on with this change. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
optionally see Louis' comment
fa57f34
to
accba47
Compare
|
Now updated code and screenshots to show the recommended apps alongside the install button |
This comment has been minimized.
This comment has been minimized.
accba47
to
06d2a04
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks code !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems to work
Maybe we could think about removing the checkbox now that you need to press a button to start the installation of the apps either way:

Also we could think about renaming the desciption of the button from Finish installation to Continue installation as this is not the last step if you don't uncheck the Install recommended apps checkbox?
06d2a04
to
4e24b56
Compare
This comment has been minimized.
This comment has been minimized.
|
Checkbox removed and wording updated, plus updated screenshots |
4e24b56
to
cf0f4db
Compare
cf0f4db
to
cee875c
Compare
Signed-off-by: Christopher Ng <chrng8@gmail.com>
cee875c
to
2276876
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works
(but didn't review the code)
Thanks for adressing my comment :)
|
backport to stable23 #30747 |
|
backport to stable22 #30748 |
|
backport to stable21 #30749 |
Now with the satisfaction of clicking a button :)