New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable11] generate correct path for owner and use the display name #3080

Merged
merged 1 commit into from Jan 16, 2017

Conversation

Projects
None yet
5 participants
@schiessle
Member

schiessle commented Jan 16, 2017

Use the display name if we send a share by mail instead of the user id.

backport of #3033

cc @nickvergessen @blizzz @rullzer for review, Thanks!

generate correct path for owner and use the display name instead of t…
…he user id

Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
@mention-bot

This comment has been minimized.

Show comment
Hide comment
@mention-bot

mention-bot Jan 16, 2017

@schiessle, thanks for your PR! By analyzing the history of the files in this pull request, we identified @LukasReschke to be a potential reviewer.

mention-bot commented Jan 16, 2017

@schiessle, thanks for your PR! By analyzing the history of the files in this pull request, we identified @LukasReschke to be a potential reviewer.

@nickvergessen

This comment has been minimized.

Show comment
Hide comment
@nickvergessen

nickvergessen Jan 16, 2017

Member

👍 but this has no tests at all :(

Member

nickvergessen commented Jan 16, 2017

👍 but this has no tests at all :(

@MorrisJobke MorrisJobke merged commit d27f36f into stable11 Jan 16, 2017

1 of 2 checks passed

continuous-integration/drone/pr the build failed
Details
continuous-integration/drone/push the build was successful
Details

@MorrisJobke MorrisJobke deleted the share-by-mail-use-display-name-stable11 branch Jan 16, 2017

@ronroze

This comment has been minimized.

Show comment
Hide comment
@ronroze

ronroze Jan 26, 2017

This fix solved the display name issue, but there is another one which is probably related - the SMTP sender name is now the local part of the Email address, instead of the sender's real name (as it was before NC v11).
For example:
I have a domain account called "Company Files Exchange" with email address files@company.com that is configured on the NC server.
Share Emails used to be sent under the name "Company Files Exchange", now they are sent under the name "files".

ronroze commented Jan 26, 2017

This fix solved the display name issue, but there is another one which is probably related - the SMTP sender name is now the local part of the Email address, instead of the sender's real name (as it was before NC v11).
For example:
I have a domain account called "Company Files Exchange" with email address files@company.com that is configured on the NC server.
Share Emails used to be sent under the name "Company Files Exchange", now they are sent under the name "files".

@schiessle

This comment has been minimized.

Show comment
Hide comment
@schiessle

schiessle Feb 9, 2017

Member

@ronroze I can't reproduce it. For me it uses the sender address I defined in the mail settings. Can you elaborate it, maybe with a concrete config example and the expected header vs. the header you see. Probably the best thing would be to open a new issue for it. Thanks!

Member

schiessle commented Feb 9, 2017

@ronroze I can't reproduce it. For me it uses the sender address I defined in the mail settings. Can you elaborate it, maybe with a concrete config example and the expected header vs. the header you see. Probably the best thing would be to open a new issue for it. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment