New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable11] Escape the name for the jquery selector #3138

Merged
merged 1 commit into from Jan 18, 2017

Conversation

Projects
None yet
5 participants
@nickvergessen
Member

nickvergessen commented Jan 18, 2017

Escape the name for the jquery selector
Signed-off-by: Joas Schilling <coding@schilljs.com>
@mention-bot

This comment has been minimized.

Show comment
Hide comment
@mention-bot

mention-bot Jan 18, 2017

@nickvergessen, thanks for your PR! By analyzing the history of the files in this pull request, we identified @butonic, @ChristophWurst and @icewind1991 to be potential reviewers.

mention-bot commented Jan 18, 2017

@nickvergessen, thanks for your PR! By analyzing the history of the files in this pull request, we identified @butonic, @ChristophWurst and @icewind1991 to be potential reviewers.

@ChristophWurst

code looks good

@MorrisJobke

Tested and works 👍

@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Jan 18, 2017

Current coverage is 57.20% (diff: 100%)

Merging #3138 into stable11 will decrease coverage by 0.03%

@@           stable11      #3138   diff @@
==========================================
  Files          1148       1205     +57   
  Lines         65806      72623   +6817   
  Methods        7378       7378           
  Messages          0          0           
  Branches          0       1235   +1235   
==========================================
+ Hits          37669      41546   +3877   
- Misses        28137      31077   +2940   
  Partials          0          0           

Powered by Codecov. Last update 0c8220d...d17635b

codecov-io commented Jan 18, 2017

Current coverage is 57.20% (diff: 100%)

Merging #3138 into stable11 will decrease coverage by 0.03%

@@           stable11      #3138   diff @@
==========================================
  Files          1148       1205     +57   
  Lines         65806      72623   +6817   
  Methods        7378       7378           
  Messages          0          0           
  Branches          0       1235   +1235   
==========================================
+ Hits          37669      41546   +3877   
- Misses        28137      31077   +2940   
  Partials          0          0           

Powered by Codecov. Last update 0c8220d...d17635b

@ChristophWurst ChristophWurst merged commit ecb6354 into stable11 Jan 18, 2017

4 checks passed

codecov/patch Coverage not affected when comparing 0c8220d...d17635b
Details
codecov/project Absolute coverage decreased by -0.03% but relative coverage increased by +42.75% compared to 0c8220d
Details
continuous-integration/drone/pr the build was successful
Details
continuous-integration/drone/push the build was successful
Details

@ChristophWurst ChristophWurst deleted the backport-2776-prevent-quotes-from-being-a-problem branch Jan 18, 2017

@MorrisJobke MorrisJobke referenced this pull request Mar 9, 2017

Closed

Directory name #3786

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment