New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable11] popovermenu backport #3286

Merged
merged 3 commits into from Feb 10, 2017

Conversation

@skjnldsv
Member

skjnldsv commented Jan 26, 2017

Backport of the corrected popovermenu.

Main ref: #3024 #3118 #3035
Additional ref: nextcloud/contacts#101

Tests: file action popover, calendar popover, user personal info privacy popover, mail account popover...

@nextcloud/designers

@skjnldsv skjnldsv added the design label Jan 26, 2017

@skjnldsv skjnldsv added this to the Nextcloud 11.0.2 milestone Jan 26, 2017

@skjnldsv skjnldsv self-assigned this Jan 26, 2017

skjnldsv added some commits Jan 26, 2017

Popover backport from 12
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Fit federationScopeMenu to guidelines
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Fit newFileMenu to css guidelines
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>

@skjnldsv skjnldsv referenced this pull request Jan 26, 2017

Merged

Addressbooklist in a popover #101

10 of 10 tasks complete

@skjnldsv skjnldsv requested a review from icewind1991 Feb 2, 2017

@skjnldsv

This comment has been minimized.

Show comment
Hide comment
@skjnldsv
Member

skjnldsv commented Feb 2, 2017

@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Feb 2, 2017

Codecov Report

Merging #3286 into stable11 will increase coverage by <.01%.

@@             Coverage Diff              @@
##           stable11    #3286      +/-   ##
============================================
+ Coverage     57.13%   57.14%   +<.01%     
============================================
  Files          1206     1206              
  Lines         72718    72718              
  Branches       1235     1235              
============================================
+ Hits          41550    41553       +3     
+ Misses        31168    31165       -3
Impacted Files Coverage Δ
lib/private/Server.php 92.72% <ø> (+0.16%)
lib/private/Files/Storage/DAV.php 7.32% <ø> (+0.23%)
lib/private/Files/Cache/Propagator.php 96.2% <ø> (+1.26%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 475e466...9e7afbf. Read the comment docs.

codecov-io commented Feb 2, 2017

Codecov Report

Merging #3286 into stable11 will increase coverage by <.01%.

@@             Coverage Diff              @@
##           stable11    #3286      +/-   ##
============================================
+ Coverage     57.13%   57.14%   +<.01%     
============================================
  Files          1206     1206              
  Lines         72718    72718              
  Branches       1235     1235              
============================================
+ Hits          41550    41553       +3     
+ Misses        31168    31165       -3
Impacted Files Coverage Δ
lib/private/Server.php 92.72% <ø> (+0.16%)
lib/private/Files/Storage/DAV.php 7.32% <ø> (+0.23%)
lib/private/Files/Cache/Propagator.php 96.2% <ø> (+1.26%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 475e466...9e7afbf. Read the comment docs.

@MorrisJobke

Tested and looks good :)

@skjnldsv

This comment has been minimized.

Show comment
Hide comment
@skjnldsv

skjnldsv Feb 5, 2017

Member

Bump? 🐤

Member

skjnldsv commented Feb 5, 2017

Bump? 🐤

@skjnldsv skjnldsv requested review from Henni and irgendwie Feb 7, 2017

@nickvergessen

This comment has been minimized.

Show comment
Hide comment
@nickvergessen

nickvergessen Feb 7, 2017

Member

Backporting this will break all apps that use this?

Member

nickvergessen commented Feb 7, 2017

Backporting this will break all apps that use this?

@skjnldsv

This comment has been minimized.

Show comment
Hide comment
@skjnldsv

skjnldsv Feb 7, 2017

Member

@nickvergessen no it should not change a thing since most of the app were sort of close to the css guidelines. But it will greatly increase compatibility between stable11 and 12 for the popover! :)

Member

skjnldsv commented Feb 7, 2017

@nickvergessen no it should not change a thing since most of the app were sort of close to the css guidelines. But it will greatly increase compatibility between stable11 and 12 for the popover! :)

@LukasReschke

I'd say let's merge it for now and if we see massive problems in the RC we can revert it again.

@LukasReschke LukasReschke merged commit 020bf77 into stable11 Feb 10, 2017

4 checks passed

codecov/patch Coverage not affected when comparing 475e466...9e7afbf
Details
codecov/project 57.14% (+<.01%) compared to 475e466
Details
continuous-integration/drone/pr the build was successful
Details
continuous-integration/drone/push the build was successful
Details

@LukasReschke LukasReschke deleted the popover-backport branch Feb 10, 2017

@skjnldsv

This comment has been minimized.

Show comment
Hide comment
@skjnldsv

skjnldsv Feb 10, 2017

Member

Youhouuu! :D

Member

skjnldsv commented Feb 10, 2017

Youhouuu! :D

@skjnldsv skjnldsv referenced this pull request Feb 10, 2017

Closed

Upload dropdown broken #197

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment