New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update icewind/streams to 0.5.2 #3293

Merged
merged 1 commit into from Mar 1, 2017

Conversation

Projects
None yet
5 participants
@icewind1991
Member

icewind1991 commented Jan 27, 2017

Backport of #3157

@icewind1991 icewind1991 added this to the Nextcloud 12.0 milestone Jan 27, 2017

@icewind1991 icewind1991 requested review from rullzer and MorrisJobke Jan 27, 2017

@mention-bot

This comment has been minimized.

Show comment
Hide comment
@mention-bot

mention-bot Jan 27, 2017

@icewind1991, thanks for your PR! By analyzing the history of the files in this pull request, we identified @LukasReschke and @Xenopathic to be potential reviewers.

mention-bot commented Jan 27, 2017

@icewind1991, thanks for your PR! By analyzing the history of the files in this pull request, we identified @LukasReschke and @Xenopathic to be potential reviewers.

@MorrisJobke

This comment has been minimized.

Show comment
Hide comment
@MorrisJobke

MorrisJobke Jan 27, 2017

Member

@icewind1991 sign-off missing

Member

MorrisJobke commented Jan 27, 2017

@icewind1991 sign-off missing

@MorrisJobke

This comment has been minimized.

Show comment
Hide comment
@MorrisJobke

MorrisJobke Feb 15, 2017

Member

@icewind1991 sign-off missing

Ping

Member

MorrisJobke commented Feb 15, 2017

@icewind1991 sign-off missing

Ping

@icewind1991

This comment has been minimized.

Show comment
Hide comment
@icewind1991
Member

icewind1991 commented Feb 17, 2017

done

@MorrisJobke

This comment has been minimized.

Show comment
Hide comment
@MorrisJobke

MorrisJobke Feb 22, 2017

Member

Let's wait for this after the current RC ;)

Member

MorrisJobke commented Feb 22, 2017

Let's wait for this after the current RC ;)

@icewind1991

This comment has been minimized.

Show comment
Hide comment
@icewind1991

icewind1991 Feb 27, 2017

Member

rebased and updated 3rdparty ref

Member

icewind1991 commented Feb 27, 2017

rebased and updated 3rdparty ref

@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Feb 27, 2017

Codecov Report

Merging #3293 into stable11 will increase coverage by <.01%.
The diff coverage is n/a.

@@              Coverage Diff               @@
##             stable11    #3293      +/-   ##
==============================================
+ Coverage        57.5%   57.51%   +<.01%     
  Complexity      19484    19484              
==============================================
  Files            1211     1211              
  Lines           72648    72648              
  Branches         1235     1235              
==============================================
+ Hits            41779    41782       +3     
+ Misses          30869    30866       -3
Impacted Files Coverage Δ Complexity Δ
lib/private/Server.php 92.72% <0%> (+0.16%) 119% <0%> (ø)
lib/private/Files/Storage/DAV.php 7.32% <0%> (+0.23%) 159% <0%> (ø)
lib/private/Files/Cache/Propagator.php 96.2% <0%> (+1.26%) 16% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c2e88c6...c677ede. Read the comment docs.

codecov-io commented Feb 27, 2017

Codecov Report

Merging #3293 into stable11 will increase coverage by <.01%.
The diff coverage is n/a.

@@              Coverage Diff               @@
##             stable11    #3293      +/-   ##
==============================================
+ Coverage        57.5%   57.51%   +<.01%     
  Complexity      19484    19484              
==============================================
  Files            1211     1211              
  Lines           72648    72648              
  Branches         1235     1235              
==============================================
+ Hits            41779    41782       +3     
+ Misses          30869    30866       -3
Impacted Files Coverage Δ Complexity Δ
lib/private/Server.php 92.72% <0%> (+0.16%) 119% <0%> (ø)
lib/private/Files/Storage/DAV.php 7.32% <0%> (+0.23%) 159% <0%> (ø)
lib/private/Files/Cache/Propagator.php 96.2% <0%> (+1.26%) 16% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c2e88c6...c677ede. Read the comment docs.

@rullzer

Fine by me 👍

@icewind1991 icewind1991 referenced this pull request Feb 28, 2017

Merged

update icewind/streams to 0.5.2 #3160

1 of 1 task complete
update icewind/streams to 0.5.2
Signed-off-by: Robin Appelman <robin@icewind.nl>
@MorrisJobke

This comment has been minimized.

Show comment
Hide comment
@MorrisJobke

MorrisJobke Feb 28, 2017

Member

I updated the 3rdparty module

Member

MorrisJobke commented Feb 28, 2017

I updated the 3rdparty module

@MorrisJobke

👍 I mounted some external storages and it still works

@icewind1991 icewind1991 merged commit 1a5f849 into stable11 Mar 1, 2017

0 of 2 checks passed

continuous-integration/drone/pr the build failed
Details
continuous-integration/drone/push the build failed
Details

@icewind1991 icewind1991 deleted the streams52-11 branch Mar 1, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment