Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not send display name twice for saving #33052

Merged
merged 3 commits into from
Jul 6, 2022
Merged

Conversation

Pytal
Copy link
Member

@Pytal Pytal commented Jun 28, 2022

Additionally prevents a duplicate request to set the displayname

Signed-off-by: Christopher Ng <chrng8@gmail.com>
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal Pytal added 3. to review Waiting for reviews feature: settings labels Jun 28, 2022
@Pytal Pytal added this to the Nextcloud 25 milestone Jun 28, 2022
@Pytal Pytal requested review from nickvergessen and a team June 28, 2022 18:23
@Pytal Pytal self-assigned this Jun 28, 2022
@Pytal Pytal requested review from PVince81, ArtificialOwl and come-nc and removed request for a team June 28, 2022 18:23
@Pytal Pytal added the bug label Jun 28, 2022
@nickvergessen nickvergessen changed the title Do not save invalid display name to the database Do not send display name twice for saving Jun 29, 2022
@nickvergessen
Copy link
Member

/backport to stable24

@nickvergessen
Copy link
Member

/backport to stable23

@nickvergessen
Copy link
Member

/backport to stable22

Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jul 6, 2022
@skjnldsv skjnldsv added the high label Jul 6, 2022
@skjnldsv
Copy link
Member

skjnldsv commented Jul 6, 2022

Jsunit failure seems unrelated

@nickvergessen nickvergessen merged commit 744f1dd into master Jul 6, 2022
@nickvergessen nickvergessen deleted the fix/set-display-name branch July 6, 2022 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish bug feature: settings high
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants