New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace ownCloud with Nextcloud #3404

Merged
merged 2 commits into from Feb 9, 2017

Conversation

Projects
None yet
4 participants
@schiessle
Member

schiessle commented Feb 8, 2017

Replace "ownCloud" with "Nextcloud" in welcome.txt. This only affect stable10 branch, previews and newer branches are OK

@LukasReschke

This comment has been minimized.

Show comment
Hide comment
@LukasReschke

LukasReschke Feb 8, 2017

Member

This breaks the DAV integration tests. Care to take a look? THX.

Member

LukasReschke commented Feb 8, 2017

This breaks the DAV integration tests. Care to take a look? THX.

@schiessle

This comment has been minimized.

Show comment
Hide comment
@schiessle

schiessle Feb 8, 2017

Member

There are exceptions like "Insufficient Storage" don't think this has something to do with replacing ownCloud with Nextcloud in the welcome.txt. 😉

Let's try once more...

Member

schiessle commented Feb 8, 2017

There are exceptions like "Insufficient Storage" don't think this has something to do with replacing ownCloud with Nextcloud in the welcome.txt. 😉

Let's try once more...

@LukasReschke

This comment has been minimized.

Show comment
Hide comment
@LukasReschke

LukasReschke Feb 8, 2017

Member

There are exceptions like "Insufficient Storage" don't think this has something to do with replacing ownCloud with Nextcloud in the welcome.txt. 😉

You would be surprised 😉

https://github.com/nextcloud/server/search?utf8=%E2%9C%93&q=%22welcome.txt%22 – the DAV integration tests perform requests against welcome.txt

Member

LukasReschke commented Feb 8, 2017

There are exceptions like "Insufficient Storage" don't think this has something to do with replacing ownCloud with Nextcloud in the welcome.txt. 😉

You would be surprised 😉

https://github.com/nextcloud/server/search?utf8=%E2%9C%93&q=%22welcome.txt%22 – the DAV integration tests perform requests against welcome.txt

replace ownCloud with Nextcloud
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
@schiessle

This comment has been minimized.

Show comment
Hide comment
@schiessle

schiessle Feb 8, 2017

Member

You would be surprised

I will never understand why we use real data for testing. Shouldn't be to hard to use a dedicated test file to avoid such situations. Anyway I adjusted the tests, let's see what happens...

Member

schiessle commented Feb 8, 2017

You would be surprised

I will never understand why we use real data for testing. Shouldn't be to hard to use a dedicated test file to avoid such situations. Anyway I adjusted the tests, let's see what happens...

fix some integration tests
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>

@MorrisJobke MorrisJobke added this to the Nextcloud 10.0.4 milestone Feb 9, 2017

@MorrisJobke MorrisJobke merged commit b2c8e22 into stable10 Feb 9, 2017

2 of 3 checks passed

continuous-integration/drone/push the build failed
Details
Scrutinizer No new issues
Details
continuous-integration/drone/pr the build was successful
Details

@MorrisJobke MorrisJobke deleted the fix-welcome.txt branch Feb 9, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment