Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix password length limitation #34500

Merged
merged 2 commits into from Oct 11, 2022

Conversation

nickvergessen
Copy link
Member

Signed-off-by: Joas Schilling coding@schilljs.com

Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen added this to the Nextcloud 26 milestone Oct 10, 2022
@nickvergessen nickvergessen requested review from a team October 10, 2022 10:35
@nickvergessen nickvergessen self-assigned this Oct 10, 2022
@nickvergessen nickvergessen requested review from artonge, Pytal, szaimen, icewind1991, blizzz and CarlSchwan and removed request for a team October 10, 2022 10:35
@nickvergessen
Copy link
Member Author

/compile /

@nickvergessen
Copy link
Member Author

/backport ab05541 to stable25

@nickvergessen
Copy link
Member Author

/backport ab05541 to stable24

@nickvergessen
Copy link
Member Author

/backport ab05541 to stable23

@nickvergessen
Copy link
Member Author

/backport ab05541 to stable22

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
Copy link
Member

@blizzz blizzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

preferably 469 goes into a const, but acceptable.

@nickvergessen
Copy link
Member Author

Probably should in a follow up across the board.

if ($newpassword === null || strlen($newpassword) > 469 || $user->setPassword($newpassword) === false) {

For now magic number to improve backportability

Copy link
Contributor

@artonge artonge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this documented somewhere ?

@szaimen szaimen added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Oct 10, 2022
@nickvergessen nickvergessen merged commit 719c9c3 into master Oct 11, 2022
27 of 29 checks passed
@nickvergessen nickvergessen deleted the bugfix/noid/more-password-limitation branch October 11, 2022 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish bug feature: users and groups
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants