Propagate attributes when resharing #34502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CarlSchwan
requested review from
PVince81,
ArtificialOwl and
juliusknorr
and removed request for
a team
|
/backport to stable25 |
CarlSchwan
force-pushed
the
fix/correct-attribute-resharing
branch
from
57ad780
to
f56e2de
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
/backport to stable24 |
When updating a share, load the node from the initiator instead of the owner similar to how this is done when creating the share. Signed-off-by: Carl Schwan <carl@carlschwan.eu>
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
CarlSchwan
force-pushed
the
fix/correct-attribute-resharing
branch
from
f56e2de
to
8e3f21d
Compare
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
skjnldsv
approved these changes
Oct 18, 2022
|
Ci failure is unrelated: I double checked an /drone/src/tests/acceptance/features/app-files-sharing.feature:402 is also failling on other commits on master |
|
/backport to stable24 |
|
bot, where is my backport ? I'll do it myself |
|
stable24: #34840 |
|
The backport to stable24 failed. Please do this backport manually. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When updating a share, load the node from the initiator instead of the owner similar to how this is done when creating the share.