New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle badly named version files more gracefully and log information #34528
Handle badly named version files more gracefully and log information #34528
Conversation
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc can you add an example file name ? (ideal would be in unit tests if possible) any explanation why this is happening at all ? does PHP parse extensions differently in some versions ? |
master is 26 👀 |
To my knowledge this can only happen if there is a file in files_version with an incorrect name, but it’s better to log that correctly. See the linked issue. PHP does not parse extension differently, but trying to access $array['undefinedkey'] was a silent error before PHP 8 if I recall correctly. |
/backport to stable25 |
/backport to stable24 |
/backport to stable23 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
CI failure unrelated |
Tagging this |
Ok, I am reopening this for merging. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but didnt test
The backport to stable25 failed. Please do this backport manually. |
The backport to stable24 failed. Please do this backport manually. |
The backport to stable23 failed. Please do this backport manually. |
Fix #34085
Signed-off-by: Côme Chilliet come.chilliet@nextcloud.com