Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emit typed event when preview is requested #34799

Merged
merged 1 commit into from Oct 27, 2022
Merged

Conversation

juliushaertl
Copy link
Member

@juliushaertl juliushaertl commented Oct 25, 2022

Adds a typed event in order to replace the deprecated event that is already in place.

@juliushaertl
Copy link
Member Author

/backport to stable25

@juliushaertl
Copy link
Member Author

/backport to stable24

Copy link
Member

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@PVince81 PVince81 added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Oct 27, 2022
This was referenced Oct 27, 2022
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 🤔

lib/public/Preview/BeforeFetchPreviewEvent.php Outdated Show resolved Hide resolved
@skjnldsv
Copy link
Member

@juliushaertl can you address Christoph Wurst MSc's comment if you want this in today 😉

@skjnldsv skjnldsv added 2. developing Work in progress and removed 4. to release Ready to be released and/or waiting for tests to finish labels Oct 27, 2022
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliushaertl juliushaertl added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Oct 27, 2022
@juliushaertl juliushaertl added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Oct 27, 2022
@skjnldsv skjnldsv merged commit 5b77675 into master Oct 27, 2022
29 of 30 checks passed
@skjnldsv skjnldsv deleted the bugfix/noid/preview-event branch October 27, 2022 13:38
@ChristophWurst ChristophWurst added the pending documentation This pull request needs an associated documentation update label Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish enhancement pending documentation This pull request needs an associated documentation update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants