New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable11] LDAP's checkPassword should only catch when a user was not found #3493

Merged
merged 1 commit into from Feb 16, 2017

Conversation

@blizzz
Member

blizzz commented Feb 15, 2017

Backport of #3324 fixes #2431 (at least partly for LDAP users)

Would be good to get it into today's RC 2

@karlitschek backport granted?

LDAP's checkPassword should only catch when a user was not found, fixes
#2431

Also fixes error processing after ldap_search, due to different return format

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@mention-bot

This comment has been minimized.

Show comment
Hide comment
@mention-bot

mention-bot Feb 15, 2017

@blizzz, thanks for your PR! By analyzing the history of the files in this pull request, we identified @LukasReschke, @MorrisJobke and @Xenopathic to be potential reviewers.

mention-bot commented Feb 15, 2017

@blizzz, thanks for your PR! By analyzing the history of the files in this pull request, we identified @LukasReschke, @MorrisJobke and @Xenopathic to be potential reviewers.

@blizzz

This comment has been minimized.

Show comment
Hide comment
@blizzz

blizzz Feb 15, 2017

Member

summoning @nextcloud/ldap :)

Member

blizzz commented Feb 15, 2017

summoning @nextcloud/ldap :)

@karlitschek

This comment has been minimized.

Show comment
Hide comment
@karlitschek

karlitschek Feb 15, 2017

Member

please backport 👍

Member

karlitschek commented Feb 15, 2017

please backport 👍

@MorrisJobke

Tested and works 👍

@MorrisJobke MorrisJobke merged commit cc226b1 into stable11 Feb 16, 2017

1 of 2 checks passed

continuous-integration/drone/push the build failed
Details
continuous-integration/drone/pr the build was successful
Details

@MorrisJobke MorrisJobke deleted the backport-3324 branch Feb 16, 2017

@oparoz

This comment has been minimized.

Show comment
Hide comment
@oparoz

oparoz Feb 16, 2017

Member

💃👯👯👯💃

Member

oparoz commented Feb 16, 2017

💃👯👯👯💃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment