New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[11] return unknown free space from nullstorage #3508

Merged
merged 2 commits into from Feb 16, 2017

Conversation

Projects
None yet
5 participants
@icewind1991
Member

icewind1991 commented Feb 16, 2017

Backport of #3408 to stable11

icewind1991 and others added some commits Feb 8, 2017

return unknown free space from nullstorage
Signed-off-by: Robin Appelman <robin@icewind.nl>
Fix unit tests
Signed-off-by: Morris Jobke <hey@morrisjobke.de>

@icewind1991 icewind1991 added this to the Nextcloud 11.0.2 milestone Feb 16, 2017

@mention-bot

This comment has been minimized.

Show comment
Hide comment
@mention-bot

mention-bot Feb 16, 2017

@icewind1991, thanks for your PR! By analyzing the history of the files in this pull request, we identified @rullzer to be a potential reviewer.

mention-bot commented Feb 16, 2017

@icewind1991, thanks for your PR! By analyzing the history of the files in this pull request, we identified @rullzer to be a potential reviewer.

@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Feb 16, 2017

Codecov Report

Merging #3508 into stable11 will not change coverage.
The diff coverage is 100%.

@@             Coverage Diff             @@
##             stable11    #3508   +/-   ##
===========================================
  Coverage       57.39%   57.39%           
  Complexity      19426    19426           
===========================================
  Files            1207     1207           
  Lines           72535    72535           
  Branches         1235     1235           
===========================================
  Hits            41628    41628           
  Misses          30907    30907
Impacted Files Coverage Δ Complexity Δ
lib/private/Lockdown/Filesystem/NullStorage.php 100% <100%> (ø) 40 <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8296f1a...1319455. Read the comment docs.

codecov-io commented Feb 16, 2017

Codecov Report

Merging #3508 into stable11 will not change coverage.
The diff coverage is 100%.

@@             Coverage Diff             @@
##             stable11    #3508   +/-   ##
===========================================
  Coverage       57.39%   57.39%           
  Complexity      19426    19426           
===========================================
  Files            1207     1207           
  Lines           72535    72535           
  Branches         1235     1235           
===========================================
  Hits            41628    41628           
  Misses          30907    30907
Impacted Files Coverage Δ Complexity Δ
lib/private/Lockdown/Filesystem/NullStorage.php 100% <100%> (ø) 40 <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8296f1a...1319455. Read the comment docs.

@MorrisJobke MorrisJobke merged commit c868e37 into stable11 Feb 16, 2017

4 checks passed

codecov/patch 100% of diff hit (target 57.39%)
Details
codecov/project 57.39% (+0%) compared to 8296f1a
Details
continuous-integration/drone/pr the build was successful
Details
continuous-integration/drone/push the build was successful
Details

@MorrisJobke MorrisJobke deleted the nullstorage-free-space-11 branch Feb 16, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment