New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable11] Backport of Fix Broken UUID Attribute Detection #3521 #3528

Merged
merged 2 commits into from Feb 20, 2017

Conversation

Projects
None yet
4 participants
@blizzz
Member

blizzz commented Feb 17, 2017

No description provided.

Backport of Fix Broken UUID Attribute Detection #3521
Fix integration test by not relying on Fake instances

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>

Fix determining the UUID attribute, default of the override is null

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>

add integration test for uuid attr detection

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>

Add repair steps

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>

Background jobs can take 4k of characters only. We find a good batch size.

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>

add tests to DB group

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@mention-bot

This comment has been minimized.

Show comment
Hide comment
@mention-bot

mention-bot Feb 17, 2017

@blizzz, thanks for your PR! By analyzing the history of the files in this pull request, we identified @nickvergessen, @LukasReschke and @MorrisJobke to be potential reviewers.

mention-bot commented Feb 17, 2017

@blizzz, thanks for your PR! By analyzing the history of the files in this pull request, we identified @nickvergessen, @LukasReschke and @MorrisJobke to be potential reviewers.

@LukasReschke

Tests seem to fail. Can you check on that?

also adjust version no in unit tests
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@blizzz

This comment has been minimized.

Show comment
Hide comment
@blizzz

blizzz Feb 20, 2017

Member

Tests seem to fail. Can you check on that?

I knew exactly this would fail on exactly this point. 🤔 Anyway, resolved,

Member

blizzz commented Feb 20, 2017

Tests seem to fail. Can you check on that?

I knew exactly this would fail on exactly this point. 🤔 Anyway, resolved,

@MorrisJobke

Looks good and didn't explode 👍

@LukasReschke LukasReschke merged commit db7d7a9 into stable11 Feb 20, 2017

1 of 2 checks passed

continuous-integration/drone/push the build failed
Details
continuous-integration/drone/pr the build was successful
Details

@LukasReschke LukasReschke deleted the backport-3521 branch Feb 20, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment