Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

delete the --image-background-size variable #35547

Merged
merged 1 commit into from Dec 6, 2022

Conversation

szaimen
Copy link
Contributor

@szaimen szaimen commented Dec 1, 2022

@szaimen szaimen added the 3. to review Waiting for reviews label Dec 1, 2022
@szaimen szaimen added this to the Nextcloud 26 milestone Dec 1, 2022
@szaimen szaimen requested review from juliushaertl, skjnldsv, a team and CarlSchwan and removed request for a team December 1, 2022 18:40
Copy link
Member

@skjnldsv skjnldsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The entire block can be removed then

- if ($image === 'background') {
- 	// If background deleted is set, ignoring variable
- 	if ($backgroundDeleted) {
- 		continue;
- 	}
- }

@juliushaertl
Copy link
Member

The entire block can be removed then

Isn't it still relevant for the background image url below?

@skjnldsv
Copy link
Member

skjnldsv commented Dec 2, 2022

No, it was only there because of the apps icons gradient being applied as well as the primary.
Now that we only have full-screen images or not at all, we don't need different background sizes

@szaimen szaimen force-pushed the enh/noid/delete-background-size-variable branch from 0a49a1f to 15d8341 Compare December 3, 2022 17:27
@szaimen
Copy link
Contributor Author

szaimen commented Dec 3, 2022

The entire block can be removed then

- if ($image === 'background') {
- 	// If background deleted is set, ignoring variable
- 	if ($backgroundDeleted) {
- 		continue;
- 	}
- }

done 👍

@szaimen szaimen requested a review from skjnldsv December 3, 2022 17:27
@szaimen szaimen requested a review from a team December 4, 2022 11:06
@szaimen
Copy link
Contributor Author

szaimen commented Dec 5, 2022

/rebase

Signed-off-by: Simon L <szaimen@e.mail.de>
@nextcloud-command nextcloud-command force-pushed the enh/noid/delete-background-size-variable branch from 15d8341 to 9597036 Compare December 5, 2022 11:44
@szaimen szaimen merged commit 8124f68 into master Dec 6, 2022
@szaimen szaimen deleted the enh/noid/delete-background-size-variable branch December 6, 2022 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants