New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable11] Use the correct principal for shared addressbooks #3608

Merged
merged 1 commit into from Feb 27, 2017

Conversation

Projects
None yet
6 participants
@nickvergessen
Member

nickvergessen commented Feb 24, 2017

Backport #3598

Use the correct principal for shared addressbooks
Signed-off-by: Joas Schilling <coding@schilljs.com>
@mention-bot

This comment has been minimized.

Show comment
Hide comment
@mention-bot

mention-bot Feb 24, 2017

@nickvergessen, thanks for your PR! By analyzing the history of the files in this pull request, we identified @schiessle, @LukasReschke and @georgehrke to be potential reviewers.

mention-bot commented Feb 24, 2017

@nickvergessen, thanks for your PR! By analyzing the history of the files in this pull request, we identified @schiessle, @LukasReschke and @georgehrke to be potential reviewers.

@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Feb 24, 2017

Codecov Report

Merging #3608 into stable11 will decrease coverage by -0.07%.
The diff coverage is 100%.

@@              Coverage Diff              @@
##             stable11   #3608      +/-   ##
=============================================
- Coverage       57.57%   57.5%   -0.07%     
  Complexity      19484   19484              
=============================================
  Files            1154    1211      +57     
  Lines           65831   72648    +6817     
  Branches            0    1235    +1235     
=============================================
+ Hits            37901   41779    +3878     
- Misses          27930   30869    +2939
Impacted Files Coverage Δ Complexity Δ
apps/dav/lib/CardDAV/CardDavBackend.php 83.66% <100%> (ø) 84 <ø> (ø)
core/js/oc-dialogs.js 0.46% <ø> (ø) 0% <ø> (?)
core/search/js/search.js 37.61% <ø> (ø) 0% <ø> (?)
core/js/share.js 34.24% <ø> (ø) 0% <ø> (?)
core/js/systemtags/systemtagmodel.js 100% <ø> (ø) 0% <ø> (?)
core/js/l10n.js 97.29% <ø> (ø) 0% <ø> (?)
core/js/systemtags/systemtagscollection.js 93.33% <ø> (ø) 0% <ø> (?)
apps/systemtags/js/filesplugin.js 50% <ø> (ø) 0% <ø> (?)
apps/files_sharing/js/sharetabview.js 83.33% <ø> (ø) 0% <ø> (?)
apps/systemtags/js/systemtagsfilelist.js 73.04% <ø> (ø) 0% <ø> (?)
... and 48 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d23569...664f802. Read the comment docs.

codecov-io commented Feb 24, 2017

Codecov Report

Merging #3608 into stable11 will decrease coverage by -0.07%.
The diff coverage is 100%.

@@              Coverage Diff              @@
##             stable11   #3608      +/-   ##
=============================================
- Coverage       57.57%   57.5%   -0.07%     
  Complexity      19484   19484              
=============================================
  Files            1154    1211      +57     
  Lines           65831   72648    +6817     
  Branches            0    1235    +1235     
=============================================
+ Hits            37901   41779    +3878     
- Misses          27930   30869    +2939
Impacted Files Coverage Δ Complexity Δ
apps/dav/lib/CardDAV/CardDavBackend.php 83.66% <100%> (ø) 84 <ø> (ø)
core/js/oc-dialogs.js 0.46% <ø> (ø) 0% <ø> (?)
core/search/js/search.js 37.61% <ø> (ø) 0% <ø> (?)
core/js/share.js 34.24% <ø> (ø) 0% <ø> (?)
core/js/systemtags/systemtagmodel.js 100% <ø> (ø) 0% <ø> (?)
core/js/l10n.js 97.29% <ø> (ø) 0% <ø> (?)
core/js/systemtags/systemtagscollection.js 93.33% <ø> (ø) 0% <ø> (?)
apps/systemtags/js/filesplugin.js 50% <ø> (ø) 0% <ø> (?)
apps/files_sharing/js/sharetabview.js 83.33% <ø> (ø) 0% <ø> (?)
apps/systemtags/js/systemtagsfilelist.js 73.04% <ø> (ø) 0% <ø> (?)
... and 48 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d23569...664f802. Read the comment docs.

@LukasReschke LukasReschke merged commit fbc5bb4 into stable11 Feb 27, 2017

4 checks passed

codecov/patch 100% of diff hit (target 57.57%)
Details
codecov/project Absolute coverage decreased by -0.06% but relative coverage increased by +42.42% compared to 8d23569
Details
continuous-integration/drone/pr the build was successful
Details
continuous-integration/drone/push the build was successful
Details

@LukasReschke LukasReschke deleted the backport-3598-shared-addressbooks-fail-on-legacy-endpoint branch Feb 27, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment