New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable11] Fix saving backup codes by using a correct data uri #3652

Merged
merged 1 commit into from Feb 28, 2017

Conversation

@ChristophWurst
Member

ChristophWurst commented Feb 28, 2017

Backport of #3649

Fix saving backup codes by using a correct data uri
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
@mention-bot

This comment has been minimized.

Show comment
Hide comment
@mention-bot

mention-bot Feb 28, 2017

@ChristophWurst, thanks for your PR! By analyzing the history of the files in this pull request, we identified @nickvergessen to be a potential reviewer.

mention-bot commented Feb 28, 2017

@ChristophWurst, thanks for your PR! By analyzing the history of the files in this pull request, we identified @nickvergessen to be a potential reviewer.

@ChristophWurst ChristophWurst changed the title from Fix saving backup codes by using a correct data uri to [stable11] Fix saving backup codes by using a correct data uri Feb 28, 2017

@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Feb 28, 2017

Codecov Report

Merging #3652 into stable11 will increase coverage by <.01%.
The diff coverage is n/a.

@@              Coverage Diff               @@
##             stable11    #3652      +/-   ##
==============================================
+ Coverage        57.5%   57.51%   +<.01%     
  Complexity      19484    19484              
==============================================
  Files            1211     1211              
  Lines           72648    72648              
  Branches         1235     1235              
==============================================
+ Hits            41779    41780       +1     
+ Misses          30869    30868       -1
Impacted Files Coverage Δ Complexity Δ
lib/private/Files/Cache/Propagator.php 96.2% <0%> (+1.26%) 16% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c773500...02e41c9. Read the comment docs.

codecov-io commented Feb 28, 2017

Codecov Report

Merging #3652 into stable11 will increase coverage by <.01%.
The diff coverage is n/a.

@@              Coverage Diff               @@
##             stable11    #3652      +/-   ##
==============================================
+ Coverage        57.5%   57.51%   +<.01%     
  Complexity      19484    19484              
==============================================
  Files            1211     1211              
  Lines           72648    72648              
  Branches         1235     1235              
==============================================
+ Hits            41779    41780       +1     
+ Misses          30869    30868       -1
Impacted Files Coverage Δ Complexity Δ
lib/private/Files/Cache/Propagator.php 96.2% <0%> (+1.26%) 16% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c773500...02e41c9. Read the comment docs.

@MorrisJobke MorrisJobke merged commit 8c2fea7 into stable11 Feb 28, 2017

4 checks passed

codecov/patch Coverage not affected when comparing c773500...02e41c9
Details
codecov/project 57.51% (+<.01%) compared to c773500
Details
continuous-integration/drone/pr the build was successful
Details
continuous-integration/drone/push the build was successful
Details

@MorrisJobke MorrisJobke deleted the stable11-fix-saving-backup-codes branch Feb 28, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment