New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable11] Typecast shared mount's storage_id to int as documented + some refactor to avoid similar bugs #3658

Merged
merged 2 commits into from Mar 2, 2017

Conversation

Projects
None yet
5 participants
@GreenArchon
Contributor

GreenArchon commented Feb 28, 2017

Backport of #3588

GreenArchon added some commits Feb 21, 2017

Typecast filecache 'storage' as int to return it as documented, fixes #…
…3461

Signed-off-by: Frédéric Fortier <frederic.fortier@oronospolytechnique.com>
Refactor files' CacheEntry object creation to call cacheEntryFromData…
…() all the time thus allowing proper casts to be done

Signed-off-by: Frédéric Fortier <frederic.fortier@oronospolytechnique.com>
@mention-bot

This comment has been minimized.

Show comment
Hide comment
@mention-bot

mention-bot Feb 28, 2017

@GreenArchon, thanks for your PR! By analyzing the history of the files in this pull request, we identified @icewind1991, @rullzer and @schiessle to be potential reviewers.

mention-bot commented Feb 28, 2017

@GreenArchon, thanks for your PR! By analyzing the history of the files in this pull request, we identified @icewind1991, @rullzer and @schiessle to be potential reviewers.

@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Feb 28, 2017

Codecov Report

Merging #3658 into stable11 will decrease coverage by -0.02%.
The diff coverage is 88.88%.

@@              Coverage Diff               @@
##             stable11    #3658      +/-   ##
==============================================
- Coverage        57.5%   57.49%   -0.02%     
+ Complexity      19484    19479       -5     
==============================================
  Files            1211     1211              
  Lines           72648    72630      -18     
  Branches         1235     1235              
==============================================
- Hits            41779    41761      -18     
  Misses          30869    30869
Impacted Files Coverage Δ Complexity Δ
apps/files_sharing/lib/SharedMount.php 79.31% <0%> (ø) 26 <0> (ø)
lib/private/Files/Cache/Cache.php 96.72% <100%> (-0.19%) 93 <0> (-5)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c773500...198cd4f. Read the comment docs.

codecov-io commented Feb 28, 2017

Codecov Report

Merging #3658 into stable11 will decrease coverage by -0.02%.
The diff coverage is 88.88%.

@@              Coverage Diff               @@
##             stable11    #3658      +/-   ##
==============================================
- Coverage        57.5%   57.49%   -0.02%     
+ Complexity      19484    19479       -5     
==============================================
  Files            1211     1211              
  Lines           72648    72630      -18     
  Branches         1235     1235              
==============================================
- Hits            41779    41761      -18     
  Misses          30869    30869
Impacted Files Coverage Δ Complexity Δ
apps/files_sharing/lib/SharedMount.php 79.31% <0%> (ø) 26 <0> (ø)
lib/private/Files/Cache/Cache.php 96.72% <100%> (-0.19%) 93 <0> (-5)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c773500...198cd4f. Read the comment docs.

@rullzer rullzer added this to the Nextcloud 11.0.3 milestone Feb 28, 2017

@rullzer rullzer merged commit 15f6e8d into nextcloud:stable11 Mar 2, 2017

3 checks passed

codecov/patch 88.88% of diff hit (target 57.5%)
Details
codecov/project Absolute coverage decreased by -0.01% but relative coverage increased by +31.38% compared to c773500
Details
continuous-integration/drone/pr the build was successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment