New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Stable9] Make theming work with pretty URLs #370

Merged
merged 2 commits into from Jul 12, 2016

Conversation

Projects
None yet
4 participants
@oparoz
Member

oparoz commented Jul 11, 2016

oparoz added some commits Jul 11, 2016

oparoz
Make theming work with pretty URLs
In some envs the rewrite rules for pretty URLs apply to all CSS files, so let's not end the route name with that etension.
Fixes #315
(cherry picked from commit 839ee5e)
oparoz
Fix tests
(cherry picked from commit eceb0db)

@oparoz oparoz added this to the Nextcloud 9.0.53 milestone Jul 11, 2016

@oparoz oparoz self-assigned this Jul 11, 2016

@mention-bot

This comment has been minimized.

Show comment
Hide comment
@mention-bot

mention-bot Jul 11, 2016

@oparoz, thanks for your PR! By analyzing the annotation information on this pull request, we identified @schiessle and @LukasReschke to be potential reviewers

mention-bot commented Jul 11, 2016

@oparoz, thanks for your PR! By analyzing the annotation information on this pull request, we identified @schiessle and @LukasReschke to be potential reviewers

@LukasReschke

This comment has been minimized.

Show comment
Hide comment
@LukasReschke

LukasReschke Jul 11, 2016

Member

LGTM. Thanks @oparoz 🚀

Member

LukasReschke commented Jul 11, 2016

LGTM. Thanks @oparoz 🚀

@MariusBluem

This comment has been minimized.

Show comment
Hide comment
@MariusBluem

MariusBluem Jul 12, 2016

Member

Let's do this 👍

Member

MariusBluem commented Jul 12, 2016

Let's do this 👍

@MariusBluem MariusBluem merged commit d35d9d2 into stable9 Jul 12, 2016

4 checks passed

Scrutinizer No new issues
Details
approvals/lgtm this commit looks good
continuous-integration/drone the build was successful
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@MariusBluem MariusBluem deleted the stable9-backport-361 branch Jul 12, 2016

@LukasReschke LukasReschke referenced this pull request Jul 14, 2016

Closed

Theming not saved #401

@oparoz oparoz removed the 3. to review label Aug 12, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment