Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc(config): Rearrange sample config into appropriate sections #38169

Merged
merged 1 commit into from May 12, 2023
Merged

doc(config): Rearrange sample config into appropriate sections #38169

merged 1 commit into from May 12, 2023

Conversation

ChristophWurst
Copy link
Member

Summary

Organize the https://docs.nextcloud.com/server/latest/admin_manual/configuration_server/config_sample_php_parameters.html page.

  • secret into Default parameters
  • defaultapp into Apps
  • skeletondirectory and templatedirectory into User experience
  • ldaplogfile into LDAP

Checklist

@ChristophWurst
doc(config): Rearrange sample config into appropriate sections
00d6a6f 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
@ChristophWurst ChristophWurst added the 3. to review Waiting for reviews label May 10, 2023
@ChristophWurst ChristophWurst added this to the Nextcloud 27 milestone May 10, 2023
@ChristophWurst ChristophWurst self-assigned this May 10, 2023
AndyScherzinger
AndyScherzinger approved these changes May 10, 2023
View reviewed changes
Copy link
Member

@AndyScherzinger AndyScherzinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fine by me 👍

nickvergessen
nickvergessen approved these changes May 10, 2023
View reviewed changes
Copy link
Member

@nickvergessen nickvergessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had a similar thing planned to bring in more suitable headings :D

@ChristophWurst ChristophWurst added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels May 10, 2023
@skjnldsv skjnldsv mentioned this pull request May 10, 2023
Merged
@ChristophWurst ChristophWurst merged commit 3aa3d7f into master May 12, 2023
34 of 37 checks passed
@ChristophWurst ChristophWurst deleted the doc/config/rearrange-sample-config branch May 12, 2023 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickvergessen nickvergessen nickvergessen approved these changes

@AndyScherzinger AndyScherzinger AndyScherzinger approved these changes

@juliushaertl juliushaertl Awaiting requested review from juliushaertl

Assignees

@ChristophWurst ChristophWurst

Labels
4. to release Ready to be released and/or waiting for tests to finish
Projects
💌 📅 👥 Groupware team
Archived in project
Milestone
Nextcloud 27
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ChristophWurst @nickvergessen @AndyScherzinger