diff --git a/apps/federatedfilesharing/lib/AddressHandler.php b/apps/federatedfilesharing/lib/AddressHandler.php index 66af86b915954..ae9ff9be34b32 100644 --- a/apps/federatedfilesharing/lib/AddressHandler.php +++ b/apps/federatedfilesharing/lib/AddressHandler.php @@ -130,9 +130,9 @@ public function compareAddresses($user1, $server1, $user2, $server2) { * @return string */ public function removeProtocolFromUrl($url) { - if (strpos($url, 'https://') === 0) { + if (str_starts_with($url, 'https://')) { return substr($url, strlen('https://')); - } elseif (strpos($url, 'http://') === 0) { + } elseif (str_starts_with($url, 'http://')) { return substr($url, strlen('http://')); } @@ -146,8 +146,8 @@ public function removeProtocolFromUrl($url) { * @return bool */ public function urlContainProtocol($url) { - if (strpos($url, 'https://') === 0 || - strpos($url, 'http://') === 0) { + if (str_starts_with($url, 'https://') || + str_starts_with($url, 'http://')) { return true; } diff --git a/apps/federatedfilesharing/lib/Notifier.php b/apps/federatedfilesharing/lib/Notifier.php index 563b121ce5bd8..ffbc3868a3a95 100644 --- a/apps/federatedfilesharing/lib/Notifier.php +++ b/apps/federatedfilesharing/lib/Notifier.php @@ -202,9 +202,9 @@ protected function createRemoteUser(string $cloudId, string $displayName = '') { protected function getDisplayName(ICloudId $cloudId): string { $server = $cloudId->getRemote(); $user = $cloudId->getUser(); - if (strpos($server, 'http://') === 0) { + if (str_starts_with($server, 'http://')) { $server = substr($server, strlen('http://')); - } elseif (strpos($server, 'https://') === 0) { + } elseif (str_starts_with($server, 'https://')) { $server = substr($server, strlen('https://')); } diff --git a/apps/federatedfilesharing/lib/OCM/CloudFederationProviderFiles.php b/apps/federatedfilesharing/lib/OCM/CloudFederationProviderFiles.php index 5d6a11c2ffde0..923214f0f2d53 100644 --- a/apps/federatedfilesharing/lib/OCM/CloudFederationProviderFiles.php +++ b/apps/federatedfilesharing/lib/OCM/CloudFederationProviderFiles.php @@ -116,7 +116,7 @@ public function shareReceived(ICloudFederationShare $share) { [$ownerUid, $remote] = $this->addressHandler->splitUserRemote($share->getOwner()); // for backward compatibility make sure that the remote url stored in the // database ends with a trailing slash - if (substr($remote, -1) !== '/') { + if (!str_ends_with($remote, '/')) { $remote = $remote . '/'; }