New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable11] Fix reshare with user activity message #3981

Merged
merged 1 commit into from Mar 22, 2017

Conversation

Projects
None yet
6 participants
@MorrisJobke
Member

MorrisJobke commented Mar 21, 2017

cc @LukasReschke @rullzer @nickvergessen

@karlitschek I guess this backport is fine?

Fix reshare with user activity message
Signed-off-by: Joas Schilling <coding@schilljs.com>

@MorrisJobke MorrisJobke added this to the Nextcloud 11.0.3 milestone Mar 21, 2017

@mention-bot

This comment has been minimized.

Show comment
Hide comment
@mention-bot

mention-bot Mar 21, 2017

@MorrisJobke, thanks for your PR! By analyzing the history of the files in this pull request, we identified @nickvergessen to be a potential reviewer.

mention-bot commented Mar 21, 2017

@MorrisJobke, thanks for your PR! By analyzing the history of the files in this pull request, we identified @nickvergessen to be a potential reviewer.

@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Mar 21, 2017

Codecov Report

Merging #3981 into stable11 will not change coverage.
The diff coverage is 0%.

@@            Coverage Diff             @@
##             stable11   #3981   +/-   ##
==========================================
  Coverage        57.5%   57.5%           
  Complexity      19500   19500           
==========================================
  Files            1211    1211           
  Lines           72678   72678           
  Branches         1235    1235           
==========================================
  Hits            41792   41792           
  Misses          30886   30886
Impacted Files Coverage Δ Complexity Δ
...pps/files_sharing/lib/Activity/Providers/Users.php 0% <0%> (ø) 21 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d8014f...9dca9ff. Read the comment docs.

codecov-io commented Mar 21, 2017

Codecov Report

Merging #3981 into stable11 will not change coverage.
The diff coverage is 0%.

@@            Coverage Diff             @@
##             stable11   #3981   +/-   ##
==========================================
  Coverage        57.5%   57.5%           
  Complexity      19500   19500           
==========================================
  Files            1211    1211           
  Lines           72678   72678           
  Branches         1235    1235           
==========================================
  Hits            41792   41792           
  Misses          30886   30886
Impacted Files Coverage Δ Complexity Δ
...pps/files_sharing/lib/Activity/Providers/Users.php 0% <0%> (ø) 21 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d8014f...9dca9ff. Read the comment docs.

@karlitschek

This comment has been minimized.

Show comment
Hide comment
@karlitschek

karlitschek Mar 22, 2017

Member

sbsolutely. please backport

Member

karlitschek commented Mar 22, 2017

sbsolutely. please backport

@nickvergessen nickvergessen merged commit f5330ed into stable11 Mar 22, 2017

3 of 4 checks passed

codecov/patch 0% of diff hit (target 57.5%)
Details
codecov/project 57.5% remains the same compared to 5d8014f
Details
continuous-integration/drone/pr the build was successful
Details
continuous-integration/drone/push the build was successful
Details

@nickvergessen nickvergessen deleted the stable11-3974 branch Mar 22, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment