New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theming fixes stable9 #406

Merged
merged 4 commits into from Jul 18, 2016

Conversation

Projects
None yet
4 participants
@nickvergessen
Member

nickvergessen commented Jul 15, 2016

nickvergessen added some commits Jul 15, 2016

@nickvergessen nickvergessen added this to the Nextcloud 9.0.53 milestone Jul 15, 2016

@nickvergessen nickvergessen referenced this pull request Jul 15, 2016

Merged

Theming fixes #405

$slogan = $this->getSlogan();
$footer = '<a href="'. $this->getBaseUrl() . '" target="_blank"' .
' rel="noreferrer">' .$this->getEntity() . '</a>'.
($slogan !== '' ? '' . $slogan : '');

This comment has been minimized.

@LukasReschke

LukasReschke Jul 15, 2016

Member

Unit test? 😉

@LukasReschke

LukasReschke Jul 15, 2016

Member

Unit test? 😉

This comment has been minimized.

@nickvergessen
@nickvergessen
@MorrisJobke

This comment has been minimized.

Show comment
Hide comment
@MorrisJobke

MorrisJobke Jul 18, 2016

Member

Tested and works 👍

Member

MorrisJobke commented Jul 18, 2016

Tested and works 👍

@schiessle

This comment has been minimized.

Show comment
Hide comment
@schiessle

schiessle Jul 18, 2016

Member

looks good 👍

Member

schiessle commented Jul 18, 2016

looks good 👍

@schiessle schiessle merged commit 174b297 into stable9 Jul 18, 2016

4 checks passed

Scrutinizer 2 updated code elements
Details
approvals/lgtm this commit looks good
continuous-integration/drone the build was successful
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@schiessle schiessle deleted the theming-fixes-stable9 branch Jul 18, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment