New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable11] Make public links work with master key #4207

Merged
merged 3 commits into from Apr 5, 2017

Conversation

Projects
None yet
4 participants
@schiessle
Member

schiessle commented Apr 4, 2017

backport of #4030

Steps to test:

  1. setup nextcloud
  2. occ app:enable encryption
  3. occ encryption:enable
  4. occ encryption:enable-master-key, answer yes
  5. Create a user "user1"
  6. Login as "user1"
  7. Create a file "bacon.txt"
  8. Share "bacon.txt" with link
  9. Log out
  10. Open link
  11. Download file

PVince81 added some commits Feb 27, 2017

Fix public link for master key
In public link mode there is no session, so the code should use the
public key instead.
@mention-bot

This comment has been minimized.

Show comment
Hide comment
@mention-bot

mention-bot Apr 4, 2017

@schiessle, thanks for your PR! By analyzing the history of the files in this pull request, we identified @LukasReschke, @nickvergessen and @rullzer to be potential reviewers.

mention-bot commented Apr 4, 2017

@schiessle, thanks for your PR! By analyzing the history of the files in this pull request, we identified @LukasReschke, @nickvergessen and @rullzer to be potential reviewers.

@schiessle

This comment has been minimized.

Show comment
Hide comment
@schiessle

schiessle Apr 4, 2017

Member

@rullzer would be awesome if you could also review the backport... Thanks! 😃

cc @nextcloud/encryption @nickvergessen for a second review

Member

schiessle commented Apr 4, 2017

@rullzer would be awesome if you could also review the backport... Thanks! 😃

cc @nextcloud/encryption @nickvergessen for a second review

@rullzer

rullzer approved these changes Apr 4, 2017

@rullzer rullzer merged commit 7f0c07f into stable11 Apr 5, 2017

0 of 2 checks passed

continuous-integration/drone/pr the build failed
Details
continuous-integration/drone/push the build failed
Details

@rullzer rullzer deleted the masterkey-publiclink-nc11 branch Apr 5, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment