New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't try to render the avatars if avatars are disabled #4214

Merged
merged 1 commit into from Apr 5, 2017

Conversation

Projects
None yet
6 participants
@schiessle
Member

schiessle commented Apr 5, 2017

The option to disable avatars was removed for Nextcloud12, nevertheless it should work for Nextcloud 11.

fix at least partially #3001

@mention-bot

This comment has been minimized.

Show comment
Hide comment
@mention-bot

mention-bot Apr 5, 2017

@schiessle, thanks for your PR! By analyzing the history of the files in this pull request, we identified @blizzz, @rullzer and @MorrisJobke to be potential reviewers.

mention-bot commented Apr 5, 2017

@schiessle, thanks for your PR! By analyzing the history of the files in this pull request, we identified @blizzz, @rullzer and @MorrisJobke to be potential reviewers.

@blizzz

blizzz approved these changes Apr 5, 2017

@rullzer

rullzer approved these changes Apr 5, 2017

@rullzer rullzer added 4. to release and removed 3. to review labels Apr 5, 2017

@nickvergessen

This comment has been minimized.

Show comment
Hide comment
@nickvergessen

nickvergessen Apr 5, 2017

Member

Sign off failed

Member

nickvergessen commented Apr 5, 2017

Sign off failed

don't try to render the avatars if avatars are disabled
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Apr 5, 2017

Codecov Report

Merging #4214 into stable11 will decrease coverage by <.01%.
The diff coverage is n/a.

@@              Coverage Diff               @@
##             stable11    #4214      +/-   ##
==============================================
- Coverage       57.48%   57.48%   -0.01%     
+ Complexity      19409    19407       -2     
==============================================
  Files            1154     1154              
  Lines           65648    65640       -8     
==============================================
- Hits            37741    37731      -10     
- Misses          27907    27909       +2
Impacted Files Coverage Δ Complexity Δ
apps/encryption/lib/KeyManager.php 78.16% <0%> (-2.01%) 78% <0%> (-2%)
lib/private/Files/Cache/Propagator.php 96.2% <0%> (+1.26%) 16% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f0c07f...616b767. Read the comment docs.

codecov-io commented Apr 5, 2017

Codecov Report

Merging #4214 into stable11 will decrease coverage by <.01%.
The diff coverage is n/a.

@@              Coverage Diff               @@
##             stable11    #4214      +/-   ##
==============================================
- Coverage       57.48%   57.48%   -0.01%     
+ Complexity      19409    19407       -2     
==============================================
  Files            1154     1154              
  Lines           65648    65640       -8     
==============================================
- Hits            37741    37731      -10     
- Misses          27907    27909       +2
Impacted Files Coverage Δ Complexity Δ
apps/encryption/lib/KeyManager.php 78.16% <0%> (-2.01%) 78% <0%> (-2%)
lib/private/Files/Cache/Propagator.php 96.2% <0%> (+1.26%) 16% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f0c07f...616b767. Read the comment docs.

@rullzer rullzer merged commit f6ebdee into stable11 Apr 5, 2017

2 of 3 checks passed

codecov/project 57.48% (-0.01%) compared to 7f0c07f
Details
codecov/patch Coverage not affected when comparing 7f0c07f...616b767
Details
continuous-integration/drone/push the build was successful
Details

@rullzer rullzer deleted the share-dialog-no-avatars branch Apr 5, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment