New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add capabilities for share by mail #4251

Merged
merged 1 commit into from Apr 10, 2017

Conversation

Projects
None yet
5 participants
@schiessle
Member

schiessle commented Apr 7, 2017

add share by mail capabilities so that the clients know if the share provider is available or not

@schiessle schiessle added this to the Nextcloud 11.0.3 milestone Apr 7, 2017

@mention-bot

This comment has been minimized.

Show comment
Hide comment
@mention-bot

mention-bot Apr 7, 2017

@schiessle, thanks for your PR! By analyzing the history of the files in this pull request, we identified @rullzer and @nickvergessen to be potential reviewers.

mention-bot commented Apr 7, 2017

@schiessle, thanks for your PR! By analyzing the history of the files in this pull request, we identified @rullzer and @nickvergessen to be potential reviewers.

@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Apr 7, 2017

Codecov Report

Merging #4251 into stable11 will increase coverage by 0.07%.
The diff coverage is 66.66%.

@@              Coverage Diff               @@
##             stable11    #4251      +/-   ##
==============================================
+ Coverage       57.38%   57.46%   +0.07%     
  Complexity      19422    19422              
==============================================
  Files            1210     1153      -57     
  Lines           72517    65701    -6816     
  Branches         1237        0    -1237     
==============================================
- Hits            41617    37754    -3863     
+ Misses          30900    27947    -2953
Impacted Files Coverage Δ Complexity Δ
apps/files_sharing/lib/Capabilities.php 85% <66.66%> (-3.58%) 6 <1> (+1)
lib/private/BackgroundJob/JobList.php 83.07% <0%> (-0.39%) 27% <0%> (-1%)
apps/user_ldap/lib/Connection.php 56.11% <0%> (-0.18%) 116% <0%> (ø)
core/js/systemtags/systemtags.js
core/js/js.js
apps/files_sharing/js/app.js
settings/js/apps.js
apps/comments/js/filesplugin.js
core/js/share.js
core/js/systemtags/systemtagsinputfield.js
... and 53 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2102935...3966b02. Read the comment docs.

codecov-io commented Apr 7, 2017

Codecov Report

Merging #4251 into stable11 will increase coverage by 0.07%.
The diff coverage is 66.66%.

@@              Coverage Diff               @@
##             stable11    #4251      +/-   ##
==============================================
+ Coverage       57.38%   57.46%   +0.07%     
  Complexity      19422    19422              
==============================================
  Files            1210     1153      -57     
  Lines           72517    65701    -6816     
  Branches         1237        0    -1237     
==============================================
- Hits            41617    37754    -3863     
+ Misses          30900    27947    -2953
Impacted Files Coverage Δ Complexity Δ
apps/files_sharing/lib/Capabilities.php 85% <66.66%> (-3.58%) 6 <1> (+1)
lib/private/BackgroundJob/JobList.php 83.07% <0%> (-0.39%) 27% <0%> (-1%)
apps/user_ldap/lib/Connection.php 56.11% <0%> (-0.18%) 116% <0%> (ø)
core/js/systemtags/systemtags.js
core/js/js.js
apps/files_sharing/js/app.js
settings/js/apps.js
apps/comments/js/filesplugin.js
core/js/share.js
core/js/systemtags/systemtagsinputfield.js
... and 53 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2102935...3966b02. Read the comment docs.

@schiessle

This comment has been minimized.

Show comment
Hide comment
@schiessle

schiessle Apr 10, 2017

Member

updated

Member

schiessle commented Apr 10, 2017

updated

add capabilities for share by mail
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
@MorrisJobke

Tested and works 👍

@MorrisJobke MorrisJobke merged commit 407831a into stable11 Apr 10, 2017

1 of 2 checks passed

continuous-integration/drone/push the build failed
Details
continuous-integration/drone/pr the build was successful
Details

@MorrisJobke MorrisJobke deleted the add-share-by-mail-capabilities branch Apr 10, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment