New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable11] make JobList::next() lock free #4254

Merged
merged 1 commit into from Apr 7, 2017

Conversation

Projects
None yet
5 participants
@MorrisJobke
Member

MorrisJobke commented Apr 7, 2017

  • backport of #4253
  • I tested it and it works fine 馃憤
make JobList::next() lock free
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
@mention-bot

This comment has been minimized.

Show comment
Hide comment
@mention-bot

mention-bot Apr 7, 2017

@MorrisJobke, thanks for your PR! By analyzing the history of the files in this pull request, we identified @nickvergessen, @icewind1991 and @Xenopathic to be potential reviewers.

mention-bot commented Apr 7, 2017

@MorrisJobke, thanks for your PR! By analyzing the history of the files in this pull request, we identified @nickvergessen, @icewind1991 and @Xenopathic to be potential reviewers.

@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Apr 7, 2017

Codecov Report

Merging #4254 into stable11 will decrease coverage by 0.01%.
The diff coverage is 87.5%.

@@              Coverage Diff               @@
##             stable11    #4254      +/-   ##
==============================================
- Coverage       57.46%   57.44%   -0.02%     
- Complexity      19421    19422       +1     
==============================================
  Files            1153     1153              
  Lines           65696    65699       +3     
==============================================
- Hits            37749    37744       -5     
- Misses          27947    27955       +8
Impacted Files Coverage 螖 Complexity 螖
lib/private/BackgroundJob/JobList.php 83.45% <87.5%> (+0.38%) 28 <0> (+1) 猬嗭笍
lib/private/DB/AdapterSqlite.php 86.2% <0%> (-13.8%) 7% <0%> (酶)
lib/private/DB/Connection.php 69.1% <0%> (-6.51%) 44% <0%> (酶)
lib/private/Server.php 92.74% <0%> (+0.16%) 119% <0%> (酶) 猬囷笍
lib/private/Files/Storage/DAV.php 7.32% <0%> (+0.23%) 159% <0%> (酶) 猬囷笍
lib/private/Files/Cache/Propagator.php 96.2% <0%> (+1.26%) 16% <0%> (酶) 猬囷笍
apps/files_trashbin/lib/Expiration.php 98.27% <0%> (+1.72%) 29% <0%> (酶) 猬囷笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 35b1f23...1bc2826. Read the comment docs.

codecov-io commented Apr 7, 2017

Codecov Report

Merging #4254 into stable11 will decrease coverage by 0.01%.
The diff coverage is 87.5%.

@@              Coverage Diff               @@
##             stable11    #4254      +/-   ##
==============================================
- Coverage       57.46%   57.44%   -0.02%     
- Complexity      19421    19422       +1     
==============================================
  Files            1153     1153              
  Lines           65696    65699       +3     
==============================================
- Hits            37749    37744       -5     
- Misses          27947    27955       +8
Impacted Files Coverage 螖 Complexity 螖
lib/private/BackgroundJob/JobList.php 83.45% <87.5%> (+0.38%) 28 <0> (+1) 猬嗭笍
lib/private/DB/AdapterSqlite.php 86.2% <0%> (-13.8%) 7% <0%> (酶)
lib/private/DB/Connection.php 69.1% <0%> (-6.51%) 44% <0%> (酶)
lib/private/Server.php 92.74% <0%> (+0.16%) 119% <0%> (酶) 猬囷笍
lib/private/Files/Storage/DAV.php 7.32% <0%> (+0.23%) 159% <0%> (酶) 猬囷笍
lib/private/Files/Cache/Propagator.php 96.2% <0%> (+1.26%) 16% <0%> (酶) 猬囷笍
apps/files_trashbin/lib/Expiration.php 98.27% <0%> (+1.72%) 29% <0%> (酶) 猬囷笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 35b1f23...1bc2826. Read the comment docs.

@rullzer

rullzer approved these changes Apr 7, 2017

@rullzer rullzer merged commit cf96f34 into stable11 Apr 7, 2017

4 checks passed

codecov/patch 87.5% of diff hit (target 57.46%)
Details
codecov/project Absolute coverage decreased by -0.01% but relative coverage increased by +30.03% compared to 35b1f23
Details
continuous-integration/drone/pr the build was successful
Details
continuous-integration/drone/push the build was successful
Details

@rullzer rullzer deleted the stable11-4253 branch Apr 7, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment