New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable11] don't remove owner property for public calendars #4272

Merged
merged 1 commit into from Apr 10, 2017

Conversation

Projects
None yet
4 participants
@LukasReschke
Member

LukasReschke commented Apr 10, 2017

Backport of #4266

don't remove owner property for public calendars
Signed-off-by: Georg Ehrke <developer@georgehrke.com>

@LukasReschke LukasReschke added this to the Nextcloud 11.0.3 milestone Apr 10, 2017

@LukasReschke LukasReschke requested review from rullzer and georgehrke Apr 10, 2017

@georgehrke

This comment has been minimized.

Show comment
Hide comment
@georgehrke

georgehrke Apr 10, 2017

Member

tested and works 👍

Member

georgehrke commented Apr 10, 2017

tested and works 👍

@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Apr 10, 2017

Codecov Report

Merging #4272 into stable11 will increase coverage by 0.01%.
The diff coverage is 93.93%.

@@              Coverage Diff              @@
##             stable11   #4272      +/-   ##
=============================================
+ Coverage       57.38%   57.4%   +0.01%     
- Complexity      19422   19433      +11     
=============================================
  Files            1210    1212       +2     
  Lines           72517   72546      +29     
  Branches         1237    1237              
=============================================
+ Hits            41617   41644      +27     
- Misses          30900   30902       +2
Impacted Files Coverage Δ Complexity Δ
apps/dav/lib/CalDAV/PublicCalendarObject.php 100% <100%> (ø) 1 <1> (?)
apps/dav/lib/CalDAV/Calendar.php 86.55% <100%> (ø) 51 <2> (ø) ⬇️
apps/dav/lib/CalDAV/CalendarObject.php 91.17% <100%> (ø) 19 <2> (ø) ⬇️
apps/dav/lib/CalDAV/PublicCalendarRoot.php 100% <100%> (ø) 4 <0> (ø) ⬇️
apps/dav/lib/CalDAV/PublicCalendar.php 92.85% <92.85%> (ø) 10 <10> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2102935...f54a3d9. Read the comment docs.

codecov-io commented Apr 10, 2017

Codecov Report

Merging #4272 into stable11 will increase coverage by 0.01%.
The diff coverage is 93.93%.

@@              Coverage Diff              @@
##             stable11   #4272      +/-   ##
=============================================
+ Coverage       57.38%   57.4%   +0.01%     
- Complexity      19422   19433      +11     
=============================================
  Files            1210    1212       +2     
  Lines           72517   72546      +29     
  Branches         1237    1237              
=============================================
+ Hits            41617   41644      +27     
- Misses          30900   30902       +2
Impacted Files Coverage Δ Complexity Δ
apps/dav/lib/CalDAV/PublicCalendarObject.php 100% <100%> (ø) 1 <1> (?)
apps/dav/lib/CalDAV/Calendar.php 86.55% <100%> (ø) 51 <2> (ø) ⬇️
apps/dav/lib/CalDAV/CalendarObject.php 91.17% <100%> (ø) 19 <2> (ø) ⬇️
apps/dav/lib/CalDAV/PublicCalendarRoot.php 100% <100%> (ø) 4 <0> (ø) ⬇️
apps/dav/lib/CalDAV/PublicCalendar.php 92.85% <92.85%> (ø) 10 <10> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2102935...f54a3d9. Read the comment docs.

@LukasReschke LukasReschke merged commit 5214405 into stable11 Apr 10, 2017

4 checks passed

codecov/patch 93.93% of diff hit (target 57.38%)
Details
codecov/project 57.4% (+0.01%) compared to 2102935
Details
continuous-integration/drone/pr the build was successful
Details
continuous-integration/drone/push the build was successful
Details

@LukasReschke LukasReschke deleted the stable11-fix_missing_owner_on_public_calendars branch Apr 10, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment