New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable11] Add missing maintenance plugin to new DAV endpoint #4290

Merged
merged 1 commit into from Apr 11, 2017

Conversation

Projects
None yet
4 participants
@LukasReschke
Member

LukasReschke commented Apr 10, 2017

Backport of #4289 to stable11

Signed-off-by: Lukas Reschke lukas@statuscode.ch

Add missing maintenance plugin to new DAV endpoint
The `/remote.php/dav/` endpoint was not implementing the MaintenancePlugin. Thus when the instance was put into maintenance mode the endpoints were still accessible and delivered empty content. Sync clients really do love this.

Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
@mention-bot

This comment has been minimized.

Show comment
Hide comment
@mention-bot

mention-bot Apr 10, 2017

@LukasReschke, thanks for your PR! By analyzing the history of the files in this pull request, we identified @nickvergessen, @icewind1991 and @rullzer to be potential reviewers.

mention-bot commented Apr 10, 2017

@LukasReschke, thanks for your PR! By analyzing the history of the files in this pull request, we identified @nickvergessen, @icewind1991 and @rullzer to be potential reviewers.

@LukasReschke LukasReschke added this to the Nextcloud 11.0.3 milestone Apr 10, 2017

@LukasReschke LukasReschke requested review from MorrisJobke and rullzer Apr 10, 2017

@MorrisJobke

Tested and works 👍

@MorrisJobke MorrisJobke merged commit baa0b32 into stable11 Apr 11, 2017

0 of 2 checks passed

continuous-integration/drone/pr the build failed
Details
continuous-integration/drone/push the build failed
Details

@MorrisJobke MorrisJobke deleted the stable11-maintenance-mode-also-on-dav branch Apr 11, 2017

@nickvergessen nickvergessen changed the title from Add missing maintenance plugin to new DAV endpoint to [stable11] Add missing maintenance plugin to new DAV endpoint Apr 11, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment