New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable11] Translation string corrected > 1 user #4377

Merged
merged 1 commit into from Apr 18, 2017

Conversation

Projects
None yet
4 participants
@MorrisJobke
Member

MorrisJobke commented Apr 18, 2017

That makes the sentence useful. Got pointed out by a translator on Transifex.

Translation string corrected > 1 user
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
@LukasReschke

Ok for me. Though we either get this in now and hope the translations are all fixed until next week or we wait for 11.0.4.

@MorrisJobke Translation sync is still in progress for stable11 – right?

@codecov

This comment has been minimized.

Show comment
Hide comment
@codecov

codecov bot Apr 18, 2017

Codecov Report

Merging #4377 into stable11 will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             stable11    #4377   +/-   ##
===========================================
  Coverage       57.39%   57.39%           
  Complexity      19439    19439           
===========================================
  Files            1214     1214           
  Lines           72567    72567           
  Branches         1237     1237           
===========================================
  Hits            41650    41650           
  Misses          30917    30917

codecov bot commented Apr 18, 2017

Codecov Report

Merging #4377 into stable11 will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             stable11    #4377   +/-   ##
===========================================
  Coverage       57.39%   57.39%           
  Complexity      19439    19439           
===========================================
  Files            1214     1214           
  Lines           72567    72567           
  Branches         1237     1237           
===========================================
  Hits            41650    41650           
  Misses          30917    30917

@LukasReschke LukasReschke added this to the Nextcloud 11.0.3 milestone Apr 18, 2017

@LukasReschke LukasReschke merged commit 29b14c4 into stable11 Apr 18, 2017

4 checks passed

codecov/patch Coverage not affected when comparing 84383bc...e57bf44
Details
codecov/project 57.39% remains the same compared to 84383bc
Details
continuous-integration/drone/pr the build was successful
Details
continuous-integration/drone/push the build was successful
Details

@LukasReschke LukasReschke deleted the stable11-2808 branch Apr 18, 2017

@MorrisJobke

This comment has been minimized.

Show comment
Hide comment
@MorrisJobke

MorrisJobke Apr 18, 2017

Member

Ok for me. Though we either get this in now and hope the translations are all fixed until next week or we wait for 11.0.4.

They are still in, because stable11 and master translations are merged and then pushed to both branches. So this is only an change of a string that is already present in master and therefore also already translated on transifex. ;)

Member

MorrisJobke commented Apr 18, 2017

Ok for me. Though we either get this in now and hope the translations are all fixed until next week or we wait for 11.0.4.

They are still in, because stable11 and master translations are merged and then pushed to both branches. So this is only an change of a string that is already present in master and therefore also already translated on transifex. ;)

@MorrisJobke

This comment has been minimized.

Show comment
Hide comment
@MorrisJobke

MorrisJobke Apr 18, 2017

Member

@MorrisJobke Translation sync is still in progress for stable11 – right?

Is executed every night (at least for the server) ;)

Member

MorrisJobke commented Apr 18, 2017

@MorrisJobke Translation sync is still in progress for stable11 – right?

Is executed every night (at least for the server) ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment