New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[11] Prevent PHP request to get killed when using fclose callback (#26775) #4491

Merged
merged 1 commit into from Apr 25, 2017

Conversation

Projects
None yet
5 participants
@icewind1991
Member

icewind1991 commented Apr 25, 2017

Backport of #3157

  • Prevent PHP request to get killed when using fclose callback

  • Add ignore_user_abort everywhere where the time limit is set to 0

Prevent PHP request to get killed when using fclose callback (#26775)
* Prevent PHP request to get killed when using fclose callback

* Add ignore_user_abort everywhere where the time limit is set to 0

Signed-off-by: Robin Appelman <robin@icewind.nl>
@mention-bot

This comment has been minimized.

Show comment
Hide comment
@mention-bot

mention-bot Apr 25, 2017

@icewind1991, thanks for your PR! By analyzing the history of the files in this pull request, we identified @LukasReschke, @nickvergessen and @schiessle to be potential reviewers.

mention-bot commented Apr 25, 2017

@icewind1991, thanks for your PR! By analyzing the history of the files in this pull request, we identified @LukasReschke, @nickvergessen and @schiessle to be potential reviewers.

@codecov

This comment has been minimized.

Show comment
Hide comment
@codecov

codecov bot Apr 25, 2017

Codecov Report

Merging #4491 into stable11 will decrease coverage by 0.05%.
The diff coverage is 25%.

@@              Coverage Diff              @@
##             stable11   #4491      +/-   ##
=============================================
- Coverage       57.46%   57.4%   -0.06%     
  Complexity      19441   19441              
=============================================
  Files            1157    1214      +57     
  Lines           65750   72573    +6823     
  Branches            0    1237    +1237     
=============================================
+ Hits            37782   41660    +3878     
- Misses          27968   30913    +2945
Impacted Files Coverage Δ Complexity Δ
lib/private/legacy/files.php 14.84% <0%> (-0.07%) 71 <0> (ø)
apps/dav/appinfo/v2/remote.php 0% <0%> (ø) 0 <0> (ø) ⬇️
apps/dav/appinfo/v1/webdav.php 0% <0%> (ø) 0 <0> (ø) ⬇️
lib/private/Files/View.php 85.69% <100%> (+0.01%) 367 <0> (ø) ⬇️
core/js/sharedialoglinkshareview.js 62.5% <0%> (ø) 0% <0%> (?)
apps/systemtags/js/systemtagsfilelist.js 73.04% <0%> (ø) 0% <0%> (?)
core/js/config.js 6.66% <0%> (ø) 0% <0%> (?)
core/js/sharedialogview.js 79.62% <0%> (ø) 0% <0%> (?)
apps/files_sharing/js/sharebreadcrumbview.js 97.36% <0%> (ø) 0% <0%> (?)
core/js/octemplate.js 11.11% <0%> (ø) 0% <0%> (?)
... and 52 more

codecov bot commented Apr 25, 2017

Codecov Report

Merging #4491 into stable11 will decrease coverage by 0.05%.
The diff coverage is 25%.

@@              Coverage Diff              @@
##             stable11   #4491      +/-   ##
=============================================
- Coverage       57.46%   57.4%   -0.06%     
  Complexity      19441   19441              
=============================================
  Files            1157    1214      +57     
  Lines           65750   72573    +6823     
  Branches            0    1237    +1237     
=============================================
+ Hits            37782   41660    +3878     
- Misses          27968   30913    +2945
Impacted Files Coverage Δ Complexity Δ
lib/private/legacy/files.php 14.84% <0%> (-0.07%) 71 <0> (ø)
apps/dav/appinfo/v2/remote.php 0% <0%> (ø) 0 <0> (ø) ⬇️
apps/dav/appinfo/v1/webdav.php 0% <0%> (ø) 0 <0> (ø) ⬇️
lib/private/Files/View.php 85.69% <100%> (+0.01%) 367 <0> (ø) ⬇️
core/js/sharedialoglinkshareview.js 62.5% <0%> (ø) 0% <0%> (?)
apps/systemtags/js/systemtagsfilelist.js 73.04% <0%> (ø) 0% <0%> (?)
core/js/config.js 6.66% <0%> (ø) 0% <0%> (?)
core/js/sharedialogview.js 79.62% <0%> (ø) 0% <0%> (?)
apps/files_sharing/js/sharebreadcrumbview.js 97.36% <0%> (ø) 0% <0%> (?)
core/js/octemplate.js 11.11% <0%> (ø) 0% <0%> (?)
... and 52 more
@blizzz

blizzz approved these changes Apr 25, 2017

@MorrisJobke

Makes sense

@MorrisJobke MorrisJobke merged commit 91fa29c into stable11 Apr 25, 2017

2 of 4 checks passed

codecov/patch 25% of diff hit (target 57.46%)
Details
codecov/project 57.4% (-0.06%) compared to ba776a3
Details
continuous-integration/drone/pr the build was successful
Details
continuous-integration/drone/push the build was successful
Details

@MorrisJobke MorrisJobke deleted the fcloseafterkill-11 branch Apr 25, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment