New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[11] round the mtime in touch #4919

Merged
merged 1 commit into from May 18, 2017

Conversation

Projects
None yet
4 participants
@icewind1991
Member

icewind1991 commented May 17, 2017

Backport of #4096

@mention-bot

This comment has been minimized.

Show comment
Hide comment
@mention-bot

mention-bot May 17, 2017

@icewind1991, thanks for your PR! By analyzing the history of the files in this pull request, we identified @nickvergessen, @LukasReschke and @schiessle to be potential reviewers.

mention-bot commented May 17, 2017

@icewind1991, thanks for your PR! By analyzing the history of the files in this pull request, we identified @nickvergessen, @LukasReschke and @schiessle to be potential reviewers.

@MorrisJobke

This comment has been minimized.

Show comment
Hide comment
@MorrisJobke

MorrisJobke May 17, 2017

Member

@sf-janz please test this

Member

MorrisJobke commented May 17, 2017

@sf-janz please test this

@MorrisJobke

This comment has been minimized.

Show comment
Hide comment
@MorrisJobke

MorrisJobke May 17, 2017

Member
There was 1 error:
1) Test\Files\ViewTest::testTouchFloat
Error: Class 'Test\Files\Filesystem' not found
/drone/src/github.com/nextcloud/server/tests/lib/Files/ViewTest.php:567
Member

MorrisJobke commented May 17, 2017

There was 1 error:
1) Test\Files\ViewTest::testTouchFloat
Error: Class 'Test\Files\Filesystem' not found
/drone/src/github.com/nextcloud/server/tests/lib/Files/ViewTest.php:567
@MorrisJobke

This comment has been minimized.

Show comment
Hide comment
@MorrisJobke

MorrisJobke May 17, 2017

Member

@sf-janz please test this

Nevermind - you tested it already: #4794 (comment)

Member

MorrisJobke commented May 17, 2017

@sf-janz please test this

Nevermind - you tested it already: #4794 (comment)

round the mtime in touch
Signed-off-by: Robin Appelman <robin@icewind.nl>
@codecov

This comment has been minimized.

Show comment
Hide comment
@codecov

codecov bot May 18, 2017

Codecov Report

Merging #4919 into stable11 will decrease coverage by 24.69%.
The diff coverage is 0%.

@@              Coverage Diff               @@
##             stable11    #4919      +/-   ##
==============================================
- Coverage        57.4%   32.71%   -24.7%     
+ Complexity      19442    19097     -345     
==============================================
  Files            1214     1207       -7     
  Lines           72570    69538    -3032     
  Branches         1237     1237              
==============================================
- Hits            41659    22747   -18912     
- Misses          30911    46791   +15880
Impacted Files Coverage Δ Complexity Δ
lib/private/Files/View.php 0.75% <0%> (-84.95%) 367 <0> (ø)
lib/private/Route/CachingRouter.php 0% <0%> (-100%) 3% <0%> (ø)
apps/user_ldap/lib/Migration/UUIDFixGroup.php 0% <0%> (-100%) 1% <0%> (ø)
...ib/private/Files/Config/UserMountCacheListener.php 0% <0%> (-100%) 2% <0%> (ø)
...s/dav/lib/Connector/Sabre/Exception/FileLocked.php 0% <0%> (-100%) 3% <0%> (ø)
lib/private/Files/Mount/LocalHomeMountProvider.php 0% <0%> (-100%) 2% <0%> (ø)
apps/user_ldap/lib/Settings/Admin.php 0% <0%> (-100%) 5% <0%> (ø)
lib/private/DB/SQLiteSessionInit.php 0% <0%> (-100%) 4% <0%> (ø)
apps/files_sharing/lib/External/MountProvider.php 0% <0%> (-100%) 4% <0%> (ø)
settings/Application.php 0% <0%> (-100%) 3% <0%> (ø)
... and 499 more

codecov bot commented May 18, 2017

Codecov Report

Merging #4919 into stable11 will decrease coverage by 24.69%.
The diff coverage is 0%.

@@              Coverage Diff               @@
##             stable11    #4919      +/-   ##
==============================================
- Coverage        57.4%   32.71%   -24.7%     
+ Complexity      19442    19097     -345     
==============================================
  Files            1214     1207       -7     
  Lines           72570    69538    -3032     
  Branches         1237     1237              
==============================================
- Hits            41659    22747   -18912     
- Misses          30911    46791   +15880
Impacted Files Coverage Δ Complexity Δ
lib/private/Files/View.php 0.75% <0%> (-84.95%) 367 <0> (ø)
lib/private/Route/CachingRouter.php 0% <0%> (-100%) 3% <0%> (ø)
apps/user_ldap/lib/Migration/UUIDFixGroup.php 0% <0%> (-100%) 1% <0%> (ø)
...ib/private/Files/Config/UserMountCacheListener.php 0% <0%> (-100%) 2% <0%> (ø)
...s/dav/lib/Connector/Sabre/Exception/FileLocked.php 0% <0%> (-100%) 3% <0%> (ø)
lib/private/Files/Mount/LocalHomeMountProvider.php 0% <0%> (-100%) 2% <0%> (ø)
apps/user_ldap/lib/Settings/Admin.php 0% <0%> (-100%) 5% <0%> (ø)
lib/private/DB/SQLiteSessionInit.php 0% <0%> (-100%) 4% <0%> (ø)
apps/files_sharing/lib/External/MountProvider.php 0% <0%> (-100%) 4% <0%> (ø)
settings/Application.php 0% <0%> (-100%) 3% <0%> (ø)
... and 499 more
@icewind1991

This comment has been minimized.

Show comment
Hide comment
@icewind1991
Member

icewind1991 commented May 18, 2017

@MorrisJobke fixed

@rullzer rullzer merged commit b85fc1a into stable11 May 18, 2017

0 of 2 checks passed

continuous-integration/drone/pr the build failed
Details
continuous-integration/drone/push the build failed
Details

@rullzer rullzer deleted the touch-floor-11 branch May 18, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment