New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable11] Add layer on top of LDAP methods to catch server disconnects and attempt re-connection #5128

Merged
merged 4 commits into from Jun 1, 2017

Conversation

Projects
None yet
4 participants
@blizzz
Member

blizzz commented May 26, 2017

Backport of #5104 to stable11

cc @nextcloud/ldap @bline

bline and others added some commits May 20, 2017

special case for controlPagedResultResponse. It would be nice if ther…
…e was a generic way to pass by reference with call_user_func_array..

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
moved to something a little less invasive. back to passing CR around.
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
make sure used ldap connection resource is always up to date
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
fix paging
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@mention-bot

This comment has been minimized.

Show comment
Hide comment
@mention-bot

mention-bot May 26, 2017

@blizzz, thanks for your PR! By analyzing the history of the files in this pull request, we identified @LukasReschke, @MorrisJobke and @Xenopathic to be potential reviewers.

mention-bot commented May 26, 2017

@blizzz, thanks for your PR! By analyzing the history of the files in this pull request, we identified @LukasReschke, @MorrisJobke and @Xenopathic to be potential reviewers.

@bline

This comment has been minimized.

Show comment
Hide comment
@bline

bline May 28, 2017

Contributor

I can confirm this is working for me connecting to windows 2012r2 Active Directory. I tested with nextcloud11 and nextcloud13 (ported it to master which was pretty straight forward).

Contributor

bline commented May 28, 2017

I can confirm this is working for me connecting to windows 2012r2 Active Directory. I tested with nextcloud11 and nextcloud13 (ported it to master which was pretty straight forward).

@blizzz

This comment has been minimized.

Show comment
Hide comment
@blizzz

blizzz May 29, 2017

Member

Was also tested successfully by @linuxrrze (nextcloud/fulltextsearch#175 (comment))

Member

blizzz commented May 29, 2017

Was also tested successfully by @linuxrrze (nextcloud/fulltextsearch#175 (comment))

@rullzer

Makes sense 👍

@blizzz blizzz merged commit e1a1a1c into stable11 Jun 1, 2017

1 of 2 checks passed

continuous-integration/drone/push the build failed
Details
continuous-integration/drone/pr the build was successful
Details

@blizzz blizzz deleted the ldap-attempt-reconnect-stable11 branch Jun 1, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment