Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrations #5231

Merged
merged 18 commits into from Jul 5, 2017
Merged

Migrations #5231

merged 18 commits into from Jul 5, 2017

Conversation

@nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented Jun 2, 2017

  • Order problem with multiple major versions: #5155 (comment)
  • Change one app to test it
  • Bring back oci table/column/index length check from app:check-code
  • Fix tests

Fix #5155

@mention-bot
Copy link

@mention-bot mention-bot commented Jun 2, 2017

@nickvergessen, thanks for your PR! By analyzing the history of the files in this pull request, we identified @icewind1991, @LukasReschke and @MorrisJobke to be potential reviewers.

@nextcloud nextcloud deleted a comment from codecov bot Jun 9, 2017
@nickvergessen nickvergessen added this to the Nextcloud 13 milestone Jun 9, 2017
@codecov
Copy link

@codecov codecov bot commented Jun 9, 2017

Codecov Report

Merging #5231 into master will decrease coverage by 16.49%.
The diff coverage is 8.7%.

@@             Coverage Diff              @@
##             master    #5231      +/-   ##
============================================
- Coverage     54.03%   37.54%   -16.5%     
- Complexity    22465    22639     +174     
============================================
  Files          1389     1400      +11     
  Lines         85957    86513     +556     
  Branches       1329     1329              
============================================
- Hits          46449    32479   -13970     
- Misses        39508    54034   +14526
Impacted Files Coverage Δ Complexity Δ
lib/private/Updater.php 0% <0%> (-6.21%) 77 <0> (ø)
core/Command/Db/Migrations/ExecuteCommand.php 0% <0%> (ø) 5 <5> (?)
lib/private/Setup.php 11.48% <0%> (-0.91%) 50 <0> (ø)
...es/lib/Migration/Version1002Date20170607104347.php 0% <0%> (ø) 2 <2> (?)
lib/private/Setup/AbstractDatabase.php 0% <0%> (ø) 18 <2> (+2) ⬆️
core/register_command.php 0% <0%> (ø) 0 <0> (ø) ⬇️
lib/private/legacy/app.php 52.81% <0%> (-2.16%) 219 <0> (ø)
lib/private/App/CodeChecker/CodeChecker.php 0% <0%> (-28.95%) 14 <1> (+2)
...private/App/CodeChecker/MigrationSchemaChecker.php 0% <0%> (ø) 58 <58> (?)
lib/private/DB/SchemaWrapper.php 0% <0%> (ø) 14 <14> (?)
... and 509 more

Copy link
Member

@rullzer rullzer left a comment

Awesome stuff. I think we should get this in ASAP to iron out bugs in the dev cycle!

nickvergessen added 14 commits Jul 5, 2017
Fixme:
- Install and update of apps
- No revert on live systems (debug only)
- Service adjustment to our interface
- Loading via autoloader

Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
…e migrations

Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
@MorrisJobke
Copy link
Member

@MorrisJobke MorrisJobke commented Jul 5, 2017

I fixed the merge conflict, but now the personal_sections table is not existent. @nickvergessen Could you fix that?

@MorrisJobke
Copy link
Member

@MorrisJobke MorrisJobke commented Jul 5, 2017

I did an update from stable12 to this and it caused that error:

Doctrine\DBAL\Exception\TableNotFoundException: An exception occurred while executing 'SELECT "class" FROM "oc_personal_sections" WHERE "class" = ? LIMIT 1' with params ["OCA\\FederatedFileSharing\\Settings\\PersonalSection"]: SQLSTATE[HY000]: General error: 1 no such table: oc_personal_sections

@nickvergessen
Copy link
Member Author

@nickvergessen nickvergessen commented Jul 5, 2017

Wonderful, I love merge conflicts and follow up problems.

Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
Copy link
Member Author

@nickvergessen nickvergessen commented Jul 5, 2017

Fixed, please merge asap.
Then we can move the existing DB to migrations as well and be done with this.

Copy link
Member

@MorrisJobke MorrisJobke left a comment

Works well

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
@MorrisJobke MorrisJobke merged commit 60398b9 into master Jul 5, 2017
1 of 2 checks passed
1 of 2 checks passed
continuous-integration/drone/pr the build failed
Details
Scrutinizer 5 new issues, 3 updated code elements
Details
@MorrisJobke MorrisJobke deleted the migrations branch Jul 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

4 participants