New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable12] urldecode group principals in Cal- and CardDAV backend #5299

Merged
merged 1 commit into from Jun 15, 2017

Conversation

Projects
None yet
4 participants
@georgehrke
Member

georgehrke commented Jun 8, 2017

backport of #5298
fixes #4885

@georgehrke georgehrke added this to the Nextcloud 12.0.1 milestone Jun 8, 2017

@georgehrke georgehrke requested a review from rullzer Jun 8, 2017

@mention-bot

This comment has been minimized.

Show comment
Hide comment
@mention-bot

mention-bot Jun 8, 2017

@georgehrke, thanks for your PR! By analyzing the history of the files in this pull request, we identified @nickvergessen, @tcitworld and @schiessle to be potential reviewers.

mention-bot commented Jun 8, 2017

@georgehrke, thanks for your PR! By analyzing the history of the files in this pull request, we identified @nickvergessen, @tcitworld and @schiessle to be potential reviewers.

@georgehrke georgehrke changed the title from urldecode group principals in Cal- and CardDAV backend to [stable12] urldecode group principals in Cal- and CardDAV backend Jun 8, 2017

urldecode group principals in Cal- and CardDAV backend
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
@codecov

This comment has been minimized.

Show comment
Hide comment
@codecov

codecov bot Jun 12, 2017

Codecov Report

Merging #5299 into stable12 will increase coverage by <.01%.
The diff coverage is 100%.

@@              Coverage Diff               @@
##             stable12    #5299      +/-   ##
==============================================
+ Coverage       54.18%   54.18%   +<.01%     
  Complexity      22296    22296              
==============================================
  Files            1380     1380              
  Lines           85347    85351       +4     
  Branches         1322     1322              
==============================================
+ Hits            46244    46247       +3     
- Misses          39103    39104       +1
Impacted Files Coverage Δ Complexity Δ
apps/dav/lib/CalDAV/CalDavBackend.php 86.03% <100%> (+0.02%) 218 <0> (ø) ⬇️
apps/dav/lib/CardDAV/CardDavBackend.php 85.74% <100%> (+0.06%) 88 <0> (ø) ⬇️
apps/comments/lib/EventHandler.php 79.16% <0%> (-8.34%) 7% <0%> (ø)
lib/private/Files/Cache/Propagator.php 96.2% <0%> (+1.26%) 16% <0%> (ø) ⬇️

codecov bot commented Jun 12, 2017

Codecov Report

Merging #5299 into stable12 will increase coverage by <.01%.
The diff coverage is 100%.

@@              Coverage Diff               @@
##             stable12    #5299      +/-   ##
==============================================
+ Coverage       54.18%   54.18%   +<.01%     
  Complexity      22296    22296              
==============================================
  Files            1380     1380              
  Lines           85347    85351       +4     
  Branches         1322     1322              
==============================================
+ Hits            46244    46247       +3     
- Misses          39103    39104       +1
Impacted Files Coverage Δ Complexity Δ
apps/dav/lib/CalDAV/CalDavBackend.php 86.03% <100%> (+0.02%) 218 <0> (ø) ⬇️
apps/dav/lib/CardDAV/CardDavBackend.php 85.74% <100%> (+0.06%) 88 <0> (ø) ⬇️
apps/comments/lib/EventHandler.php 79.16% <0%> (-8.34%) 7% <0%> (ø)
lib/private/Files/Cache/Propagator.php 96.2% <0%> (+1.26%) 16% <0%> (ø) ⬇️

@georgehrke georgehrke requested review from nickvergessen and schiessle Jun 12, 2017

@MorrisJobke MorrisJobke merged commit c20faa1 into stable12 Jun 15, 2017

3 checks passed

codecov/patch 100% of diff hit (target 54.18%)
Details
codecov/project 54.18% (+<.01%) compared to acda3a2
Details
continuous-integration/drone/pr the build was successful
Details

@MorrisJobke MorrisJobke deleted the bugfix-stable12/4885/calendar_shares_url_special_char_issue branch Jun 15, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment