New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable12] Treat PHP Errors on User session regenerate #5422

Merged
merged 1 commit into from Jun 15, 2017

Conversation

Projects
None yet
3 participants
@blizzz
Member

blizzz commented Jun 15, 2017

Forward port of #5190 to stable12

Forward port of #5190 to stable12
Treat PHP Errors on User session regenerate

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>

remove unnecessary lines…

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>

change PHP errors to ErrorException in the session (PHP >=7)

Otherwise it might be that authentication apps are being disabled on
during operation while in fact the session handler has hiccup.

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@codecov

This comment has been minimized.

Show comment
Hide comment
@codecov

codecov bot Jun 15, 2017

Codecov Report

Merging #5422 into stable12 will decrease coverage by <.01%.
The diff coverage is 0%.

@@              Coverage Diff               @@
##             stable12    #5422      +/-   ##
==============================================
- Coverage       54.16%   54.15%   -0.01%     
- Complexity      22306    22310       +4     
==============================================
  Files            1380     1380              
  Lines           85457    85468      +11     
  Branches         1326     1326              
==============================================
- Hits            46286    46284       -2     
- Misses          39171    39184      +13
Impacted Files Coverage Δ Complexity Δ
lib/private/Session/Internal.php 0% <0%> (ø) 23 <3> (+4) ⬆️
apps/comments/lib/EventHandler.php 79.16% <0%> (-8.34%) 7% <0%> (ø)
lib/private/Security/CertificateManager.php 90.81% <0%> (-1.03%) 39% <0%> (ø)
lib/private/Server.php 93.41% <0%> (+0.14%) 120% <0%> (ø) ⬇️

codecov bot commented Jun 15, 2017

Codecov Report

Merging #5422 into stable12 will decrease coverage by <.01%.
The diff coverage is 0%.

@@              Coverage Diff               @@
##             stable12    #5422      +/-   ##
==============================================
- Coverage       54.16%   54.15%   -0.01%     
- Complexity      22306    22310       +4     
==============================================
  Files            1380     1380              
  Lines           85457    85468      +11     
  Branches         1326     1326              
==============================================
- Hits            46286    46284       -2     
- Misses          39171    39184      +13
Impacted Files Coverage Δ Complexity Δ
lib/private/Session/Internal.php 0% <0%> (ø) 23 <3> (+4) ⬆️
apps/comments/lib/EventHandler.php 79.16% <0%> (-8.34%) 7% <0%> (ø)
lib/private/Security/CertificateManager.php 90.81% <0%> (-1.03%) 39% <0%> (ø)
lib/private/Server.php 93.41% <0%> (+0.14%) 120% <0%> (ø) ⬇️

@MorrisJobke MorrisJobke merged commit 20d994f into stable12 Jun 15, 2017

1 of 3 checks passed

codecov/patch 0% of diff hit (target 54.16%)
Details
codecov/project 54.15% (-0.01%) compared to aeb80e0
Details
continuous-integration/drone/pr the build was successful
Details

@MorrisJobke MorrisJobke deleted the 5190-stable12 branch Jun 15, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment