New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable12] Allow to find local users by their email address #5428

Merged
merged 1 commit into from Jun 15, 2017

Conversation

@blizzz
Member

blizzz commented Jun 15, 2017

Backport of #5384 to stable12

Works also with LDAP users btw. Just cherry-picked, did not need to touch code β†’ πŸ‘ from me

Backport of #5384 to stable12
Allow to find local users by their email address

Signed-off-by: Joas Schilling <coding@schilljs.com>

Make sure to only add system users once

Signed-off-by: Joas Schilling <coding@schilljs.com>

Add unit test

Signed-off-by: Joas Schilling <coding@schilljs.com>
@MorrisJobke

Tested and works πŸ‘

@MorrisJobke MorrisJobke merged commit 3040eae into stable12 Jun 15, 2017

1 check was pending

continuous-integration/drone/pr this build is pending
Details

@MorrisJobke MorrisJobke deleted the 5384-stable12 branch Jun 15, 2017

if (isset($contact['isLocalSystemBook'])) {
if ($exactEmailMatch) {
$cloud = $this->cloudIdManager->resolveCloudId($contact['CLOUD'][0]);

This comment has been minimized.

@pierre-alain-b

pierre-alain-b Aug 13, 2017

This addition led to a crash on my NC instance: users cannot share anymore with users with an email address set in NC.

For user "pab", with an email address, $contact['CLOUD'][0] resolves to "pab@" and resolveCloudId fails saying: Invalid cloud id.

See here for full error stack: https://help.nextcloud.com/t/cant-share-to-a-local-user/12339/4?u=pab

@pierre-alain-b

pierre-alain-b Aug 13, 2017

This addition led to a crash on my NC instance: users cannot share anymore with users with an email address set in NC.

For user "pab", with an email address, $contact['CLOUD'][0] resolves to "pab@" and resolveCloudId fails saying: Invalid cloud id.

See here for full error stack: https://help.nextcloud.com/t/cant-share-to-a-local-user/12339/4?u=pab

This comment has been minimized.

@pierre-alain-b

pierre-alain-b Aug 13, 2017

Can someone tell me where the ['CLOUD'][0] value is supposed to be found? Is there a doc of the contactsManager to see to which fields of the database CLOUD shall be linked to?

@pierre-alain-b

pierre-alain-b Aug 13, 2017

Can someone tell me where the ['CLOUD'][0] value is supposed to be found? Is there a doc of the contactsManager to see to which fields of the database CLOUD shall be linked to?

This comment has been minimized.

@MorrisJobke

MorrisJobke Aug 13, 2017

Member

cc @nickvergessen this is where this weird share name could come from

@MorrisJobke

MorrisJobke Aug 13, 2017

Member

cc @nickvergessen this is where this weird share name could come from

This comment has been minimized.

@nickvergessen

nickvergessen Aug 14, 2017

Member

Fix is in #6099

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment