New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use translated Hint instead of english error on password policy #5434

Merged
merged 1 commit into from Jul 5, 2017

Conversation

Projects
None yet
3 participants
@nickvergessen
Member

nickvergessen commented Jun 16, 2017

Backport #5404

Use translated Hint instead of english error on password policy
Signed-off-by: Joas Schilling <coding@schilljs.com>
@oparoz

This comment has been minimized.

Show comment
Hide comment
@oparoz

oparoz Jun 16, 2017

Member

👍

Member

oparoz commented Jun 16, 2017

👍

@codecov

This comment has been minimized.

Show comment
Hide comment
@codecov

codecov bot Jun 16, 2017

Codecov Report

Merging #5434 into stable12 will decrease coverage by <.01%.
The diff coverage is 50%.

@@              Coverage Diff               @@
##             stable12    #5434      +/-   ##
==============================================
- Coverage       54.15%   54.15%   -0.01%     
- Complexity      22325    22327       +2     
==============================================
  Files            1380     1380              
  Lines           85522    85524       +2     
  Branches         1326     1326              
==============================================
+ Hits            46312    46313       +1     
- Misses          39210    39211       +1
Impacted Files Coverage Δ Complexity Δ
settings/Controller/UsersController.php 69.12% <50%> (-0.08%) 114 <0> (+2)

codecov bot commented Jun 16, 2017

Codecov Report

Merging #5434 into stable12 will decrease coverage by <.01%.
The diff coverage is 50%.

@@              Coverage Diff               @@
##             stable12    #5434      +/-   ##
==============================================
- Coverage       54.15%   54.15%   -0.01%     
- Complexity      22325    22327       +2     
==============================================
  Files            1380     1380              
  Lines           85522    85524       +2     
  Branches         1326     1326              
==============================================
+ Hits            46312    46313       +1     
- Misses          39210    39211       +1
Impacted Files Coverage Δ Complexity Δ
settings/Controller/UsersController.php 69.12% <50%> (-0.08%) 114 <0> (+2)

@MorrisJobke MorrisJobke merged commit 2122cfc into stable12 Jul 5, 2017

1 of 3 checks passed

codecov/patch 50% of diff hit (target 54.15%)
Details
codecov/project 54.15% (-0.01%) compared to 3cb59ac
Details
continuous-integration/drone/pr the build was successful
Details

@MorrisJobke MorrisJobke deleted the backport-5404-translated-hint-password-policy branch Jul 5, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment