New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if Circles is still here #5484

Merged
merged 2 commits into from Jul 11, 2017

Conversation

Projects
None yet
4 participants
@daita
Member

daita commented Jun 20, 2017

@daita daita added this to the Nextcloud 12.0.1 milestone Jun 20, 2017

@MorrisJobke

This comment has been minimized.

Show comment
Hide comment
@MorrisJobke

MorrisJobke Jul 11, 2017

Member

@daita And what about master?

Member

MorrisJobke commented Jul 11, 2017

@daita And what about master?

@daita

This comment has been minimized.

Show comment
Hide comment
@daita

daita Jul 11, 2017

Member

master: #5681

Member

daita commented Jul 11, 2017

master: #5681

@daita daita referenced this pull request Jul 11, 2017

Merged

upstream fix circles #5681

@nickvergessen

This comment has been minimized.

Show comment
Hide comment
@nickvergessen

nickvergessen Jul 11, 2017

Member

#CiDeasasterDay @MorrisJobke can you restart?

Member

nickvergessen commented Jul 11, 2017

#CiDeasasterDay @MorrisJobke can you restart?

daita added some commits Jun 20, 2017

verify that circles is installed
Signed-off-by: Maxence Lange <maxence@nextcloud.com>
wrong call
Signed-off-by: Maxence Lange <maxence@nextcloud.com>
@codecov

This comment has been minimized.

Show comment
Hide comment
@codecov

codecov bot Jul 11, 2017

Codecov Report

Merging #5484 into stable12 will increase coverage by 0.06%.
The diff coverage is 85.71%.

@@              Coverage Diff               @@
##             stable12    #5484      +/-   ##
==============================================
+ Coverage       54.08%   54.15%   +0.06%     
+ Complexity      22408    22329      -79     
==============================================
  Files            1379     1380       +1     
  Lines           85712    85534     -178     
  Branches         1329     1329              
==============================================
- Hits            46355    46317      -38     
+ Misses          39357    39217     -140
Impacted Files Coverage Δ Complexity Δ
...iles_sharing/lib/Controller/ShareAPIController.php 67.61% <0%> (ø) 155 <0> (+1) ⬆️
...es_sharing/lib/Controller/ShareesAPIController.php 66.03% <100%> (ø) 111 <0> (+1) ⬆️
lib/private/Share20/ProviderFactory.php 85.18% <100%> (+0.42%) 31 <0> (+2) ⬆️
lib/private/NavigationManager.php 53.03% <0%> (-27.27%) 39% <0%> (-3%)
lib/private/URLGenerator.php 75.94% <0%> (-1.69%) 50% <0%> (-14%)
lib/private/Log.php 79.01% <0%> (-0.99%) 36% <0%> (-1%)
...rovisioning_api/lib/Controller/UsersController.php 81.21% <0%> (-0.56%) 116% <0%> (-5%)
lib/private/User/Manager.php 85.02% <0%> (-0.55%) 71% <0%> (-3%)
lib/private/Template/SCSSCacher.php 68.85% <0%> (-0.51%) 34% <0%> (-1%)
.../dav/lib/Connector/Sabre/ExceptionLoggerPlugin.php 92.59% <0%> (-0.27%) 6% <0%> (+2%)
... and 41 more

codecov bot commented Jul 11, 2017

Codecov Report

Merging #5484 into stable12 will increase coverage by 0.06%.
The diff coverage is 85.71%.

@@              Coverage Diff               @@
##             stable12    #5484      +/-   ##
==============================================
+ Coverage       54.08%   54.15%   +0.06%     
+ Complexity      22408    22329      -79     
==============================================
  Files            1379     1380       +1     
  Lines           85712    85534     -178     
  Branches         1329     1329              
==============================================
- Hits            46355    46317      -38     
+ Misses          39357    39217     -140
Impacted Files Coverage Δ Complexity Δ
...iles_sharing/lib/Controller/ShareAPIController.php 67.61% <0%> (ø) 155 <0> (+1) ⬆️
...es_sharing/lib/Controller/ShareesAPIController.php 66.03% <100%> (ø) 111 <0> (+1) ⬆️
lib/private/Share20/ProviderFactory.php 85.18% <100%> (+0.42%) 31 <0> (+2) ⬆️
lib/private/NavigationManager.php 53.03% <0%> (-27.27%) 39% <0%> (-3%)
lib/private/URLGenerator.php 75.94% <0%> (-1.69%) 50% <0%> (-14%)
lib/private/Log.php 79.01% <0%> (-0.99%) 36% <0%> (-1%)
...rovisioning_api/lib/Controller/UsersController.php 81.21% <0%> (-0.56%) 116% <0%> (-5%)
lib/private/User/Manager.php 85.02% <0%> (-0.55%) 71% <0%> (-3%)
lib/private/Template/SCSSCacher.php 68.85% <0%> (-0.51%) 34% <0%> (-1%)
.../dav/lib/Connector/Sabre/ExceptionLoggerPlugin.php 92.59% <0%> (-0.27%) 6% <0%> (+2%)
... and 41 more

@MorrisJobke MorrisJobke merged commit 48351b4 into stable12 Jul 11, 2017

1 check failed

continuous-integration/drone/pr the build failed
Details

@MorrisJobke MorrisJobke deleted the fix-if-circles-is-deleted branch Jul 11, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment