New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable11] Don't try to save the setting when its not an admin #5499

Merged
merged 2 commits into from Jun 21, 2017

Conversation

Projects
None yet
4 participants
@nickvergessen
Member

nickvergessen commented Jun 21, 2017

Backport of #5459 and #5479

nickvergessen added some commits Jun 19, 2017

Don't try to save the setting when its not an admin
Signed-off-by: Joas Schilling <coding@schilljs.com>
Also allow group admins to toogle the storage location
Signed-off-by: Joas Schilling <coding@schilljs.com>
@mention-bot

This comment has been minimized.

Show comment
Hide comment
@mention-bot

mention-bot Jun 21, 2017

@nickvergessen, thanks for your PR! By analyzing the history of the files in this pull request, we identified @MorrisJobke, @ringmaster and @blizzz to be potential reviewers.

mention-bot commented Jun 21, 2017

@nickvergessen, thanks for your PR! By analyzing the history of the files in this pull request, we identified @MorrisJobke, @ringmaster and @blizzz to be potential reviewers.

@MorrisJobke

Tested and works 👍

@MorrisJobke MorrisJobke merged commit 56c345b into stable11 Jun 21, 2017

0 of 2 checks passed

continuous-integration/drone/pr the build failed
Details
continuous-integration/drone/push the build failed
Details

@MorrisJobke MorrisJobke deleted the backport-5459-dont-reload-on-subadmin-setting-change branch Jun 21, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment